Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44681 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89226 invoked from network); 3 Jul 2009 13:35:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2009 13:35:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.198.224 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.198.224 rv-out-0506.google.com Received: from [209.85.198.224] ([209.85.198.224:18368] helo=rv-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8A/F3-27980-C190E4A4 for ; Fri, 03 Jul 2009 09:35:24 -0400 Received: by rv-out-0506.google.com with SMTP id l9so836367rvb.23 for ; Fri, 03 Jul 2009 06:35:21 -0700 (PDT) Received: by 10.141.29.14 with SMTP id g14mr1096878rvj.189.1246628120637; Fri, 03 Jul 2009 06:35:20 -0700 (PDT) Received: from ?192.168.1.169? (TOROON63-1176059019.sdsl.bell.ca [70.25.60.139]) by mx.google.com with ESMTPS id c20sm6692377rvf.29.2009.07.03.06.35.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 03 Jul 2009 06:35:19 -0700 (PDT) Cc: Stanislav Malyshev , PHP internals Message-ID: <9B379CBB-9575-4B85-8B0B-49C1C0DFC1AC@prohost.org> To: Paul Biggar In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Fri, 3 Jul 2009 09:35:16 -0400 References: <4A4BA5C8.1020204@zend.com> X-Mailer: Apple Mail (2.935.3) Subject: Re: [PHP-DEV] RFC: Type hinting revisited for PHP 5.3 From: ilia@prohost.org (Ilia Alshanetsky) Good point, this way API could remain the same. On 3-Jul-09, at 9:31 AM, Paul Biggar wrote: > Hi Ilia, > > On Wed, Jul 1, 2009 at 7:07 PM, Stanislav Malyshev > wrote: >>> The patch is available here: http://ia.gd/patch/type_hint_53.txt >> >> Technical comment: as this patch changes binary API this shouldn't >> happen in >> 5.3 branch. So maybe it's better to make it for 6. > > > Index: Zend/zend_compile.h > =================================================================== > RCS file: /repository/ZendEngine2/zend_compile.h,v > retrieving revision 1.316.2.8.2.12.2.40 > diff -u -p -a -d -u -r1.316.2.8.2.12.2.40 zend_compile.h > --- Zend/zend_compile.h 5 Jun 2009 23:20:59 -0000 1.316.2.8.2.12.2.40 > +++ Zend/zend_compile.h 1 Jul 2009 16:45:02 -0000 > @@ -175,7 +175,7 @@ typedef struct _zend_arg_info { > zend_uint name_len; > const char *class_name; > zend_uint class_name_len; > - zend_bool array_type_hint; > + zend_uint type_hint; > zend_bool allow_null; > zend_bool pass_by_reference; > zend_bool return_reference; > > > I think you could make this work for 5.3, if it used the old > "zend_bool array_type_hint". A zend_bool is 8 bits, so that's plenty. > It would be a little bit messy, but I'm fairly confident it could be > made work. > > > Thanks, > Paul > > > > -- > Paul Biggar > paul.biggar@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >