Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44631 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99007 invoked from network); 2 Jul 2009 10:26:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Jul 2009 10:26:16 -0000 Authentication-Results: pb1.pair.com header.from=gwynne@darkrainfall.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=gwynne@darkrainfall.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain darkrainfall.org from 208.97.132.119 cause and error) X-PHP-List-Original-Sender: gwynne@darkrainfall.org X-Host-Fingerprint: 208.97.132.119 balanced.mail.policyd.dreamhost.com Received: from [208.97.132.119] ([208.97.132.119:35537] helo=homiemail-a1.g.dreamhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8E/20-32416-74B8C4A4 for ; Thu, 02 Jul 2009 06:26:16 -0400 Received: from Moonstar.home (pool-71-174-84-161.bstnma.fios.verizon.net [71.174.84.161]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by homiemail-a1.g.dreamhost.com (Postfix) with ESMTP id D3D9A119DC3 for ; Thu, 2 Jul 2009 03:26:12 -0700 (PDT) Message-ID: To: PHP internals Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 2 Jul 2009 06:26:11 -0400 X-Mailer: Apple Mail (2.935.3) Subject: Tiny correction to type hinting patch From: gwynne@darkrainfall.org (Gwynne Raskind) In Ilia's type hinting patch, on line 255, is the line: +"string"|"binary"|"unicode" { This failed for me. I fixed it by changing it to: +("string"|"binary"|"unicode") { Which matches all the other lexing rules for type hints. My understanding of the lexer is insufficient to understand why this particular set of parenthesis makes any difference at all, but there you have it. -- Gwynne