Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44615
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.227 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=ddQi9kAF47JGaiGByC9NPzBv0sfST1gygrxuDV5RZuoNesSWy1GEZ4IF2qpzdu8wms
         oOzr/MB6PinZUctG9XMsjXHzq+hmNkNmSzKSo1/OUSd+2UeL1UqHk5XWUmtU3iQw5C5M
         OSFqtYnZjjfUgNgacHKvaS9mGQf2ai7kjQoV8=
MIME-Version: 1.0
In-Reply-To: <7f3ed2c30907011453y79eedad9w7c1c0c0832616285@mail.gmail.com>
References: <FC14FAFE-6785-4067-9B49-9FC14F159C52@prohost.org> 
	<39D0B97E-3A70-44E3-B1BC-D68A0E58CA76@prohost.org> <4A4BC731.1020909@zend.com> 
	<7f3ed2c30907011342y24ccd2c7te5f7c273f001fa7a@mail.gmail.com> 
	<4A4BCC0D.6000704@zend.com> <7f3ed2c30907011402taa51848h56dfff924c59a6cb@mail.gmail.com> 
	<af54caaf0907011407t7cac9aa5w6b41e634ee4c2a68@mail.gmail.com> 
	<7f3ed2c30907011423p28e693c1nc4da1e2b20ca8a45@mail.gmail.com> 
	<af54caaf0907011436g4fb119f3p929b79670d26abd7@mail.gmail.com> 
	<7f3ed2c30907011453y79eedad9w7c1c0c0832616285@mail.gmail.com>
Date: Wed, 1 Jul 2009 23:07:37 +0100
Message-ID: <af54caaf0907011507sc20b438u89e32f3e3a58e5df@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Stanislav Malyshev <stas@zend.com>, Ilia Alshanetsky <ilia@prohost.org>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: Type hinting revisited for PHP 5.3
From: paul.biggar@gmail.com (Paul Biggar)

On Wed, Jul 1, 2009 at 10:53 PM, Hannes
Magnusson<hannes.magnusson@gmail.com> wrote:
> On Wed, Jul 1, 2009 at 23:36, Paul Biggar<paul.biggar@gmail.com> wrote:
>> On Wed, Jul 1, 2009 at 10:23 PM, Hannes
>> Magnusson<hannes.magnusson@gmail.com> wrote:
>>> On Wed, Jul 1, 2009 at 23:07, Paul Biggar<paul.biggar@gmail.com> wrote:
>>>> So, what you're saying is, the patch already handles coercion? If
>>>> that's the case, then problem solved.
>>>
>>> The patch offers scalar type _hinting_. Not type _casting_.
>>>
>>> Type hinting in PHP works very simply: If the value doesn't type-match
>>> the argument information (arginfo internally) then it will be rejected
>>> and E_RECOVERABLE_ERROR thrown.
>>>
>>> In most circumstances that error is fatal. However. If the user
>>> chooses then he can ignore that error (by creating his own error
>>> handler) and continue the execution.
>>>
>>> Type _hinting_ is in no way related to type _casting_.
>>
>>
>> It should be.
>
> function foo(string $str, array $arr) {}
>
> foo(false, "foobar");
>
> You are saying that the first argument should be casted, but not the second?
> Or are you planning on breaking pretty much every single application using PHP5?

I'm sorry, I don't see what you're saying?



>> Yes. Therefore only the scalar and numeric types are useful. Nobody
>> wants to use an 'int' hint that fails on numeric strings.
>
> I do. I don't only deal with $_REQUEST stuff.
> I don't have the resources to go the Y! route. I write bunch of stuff
> in PHP. Real type hinting would help _alot_.

My point is that type hints should be like what we've been using for
years in the docs.

There is obviously a tension here. People want two different features.
I'm not sure I see a way to reconcile that (unless you'd like 'strict
int' or 'is int'?)




>> Also, I don't know what happens for string hints when you pass an
>> object with a __toString handler, but it should be allowed.
>
> Apply the patch and try?
> It would be neat if people would do a quick readthrough the patch
> before arguing against it :)

I did of course read the patch. I ask questions the way I do to avoid
confrontation, which is all too prevalent on this list.

I wanted to know what the code was intended to do, not what it does.
The patch wasnt clear without context, and it had no comments or
tests.

(FYI, I did a fairly detailed review of the type hinting patch last
year, which was ignored, so I'm reluctant to put the same effort in
here).


Thanks,
Paul



-- 
Paul Biggar
paul.biggar@gmail.com