Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44527 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7252 invoked from network); 28 Jun 2009 10:10:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jun 2009 10:10:46 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.224 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.220.224 mail-fx0-f224.google.com Received: from [209.85.220.224] ([209.85.220.224:35002] helo=mail-fx0-f224.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5A/CC-38693-4A1474A4 for ; Sun, 28 Jun 2009 06:10:45 -0400 Received: by mail-fx0-f224.google.com with SMTP id 24so2168851fxm.23 for ; Sun, 28 Jun 2009 03:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=uKbvtFWRAMVxGQ87zazAEAgPIIgvrVAA6CVK5cj6LlM=; b=FaadpNv8WVvdJ7UWNfOup+IONZTFtPKpnQCYTrBfYlaRTC17FNLY2cUkhijT8igeAp vofhV2EANyBac4ksdBYw7cGvj2gdbKhbdiCFVcavW1MWCNP1zrysGIIt7aAidwIy48dk e/C76Fwxz2f9uHd7Qq2EhRVXYPWryLJqOHBfc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=UTu2RZQOBmx/HhCcJDefyEeywAJ0Rm4ZcdJxTs9Cqv6nrJN2Kb1MFD6OmIijuK/oEL FkPnI/roU7OSfVrlP3z2AwQ2ULj8bdyqmyNey8Wf47OeVngf8VpwV4XLNk02UZSwUYuW Anpyrzf4c5Bwkl7znuXjGBAhHSCCFZyUsdpA0= MIME-Version: 1.0 Received: by 10.86.91.14 with SMTP id o14mr929351fgb.33.1246183844561; Sun, 28 Jun 2009 03:10:44 -0700 (PDT) In-Reply-To: <1246101161.13829.1.camel@goldfinger.johannes.nop> References: <4A453C43.3060806@gravitonic.com> <1246101161.13829.1.camel@goldfinger.johannes.nop> Date: Sun, 28 Jun 2009 12:10:44 +0200 Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: Andrei Zmievski , PHP internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Memory corruption bug From: pierre.php@gmail.com (Pierre Joye) committed. 2009/6/27 Johannes Schl=FCter : > On Fri, 2009-06-26 at 14:23 -0700, Andrei Zmievski wrote: >> I found what is effectively a memory corruption bug in all the branches.= pecalloc() uses >> the wrong length to zero out the memory. Patch is attached, although I'm= somewhat >> concerned about using just (nmemb*len) instead of something like safe_ad= dress(nmemb*len), >> but safe_address() is inlined in zend_alloc.c not in the header file. >> >> We should apply this to 5.2/5.3 before the release. > > Agreed. > > johanes > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Pierre http://blog.thepimp.net | http://www.libgd.org