Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44509 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92453 invoked from network); 27 Jun 2009 00:44:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2009 00:44:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.222.197 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.222.197 mail-pz0-f197.google.com Received: from [209.85.222.197] ([209.85.222.197:55651] helo=mail-pz0-f197.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 18/40-08868-A6B654A4 for ; Fri, 26 Jun 2009 20:44:26 -0400 Received: by pzk35 with SMTP id 35so2453070pzk.29 for ; Fri, 26 Jun 2009 17:44:23 -0700 (PDT) Received: by 10.114.113.11 with SMTP id l11mr5229443wac.83.1246063463575; Fri, 26 Jun 2009 17:44:23 -0700 (PDT) Received: from ?192.168.200.148? (c-69-181-146-64.hsd1.ca.comcast.net [69.181.146.64]) by mx.google.com with ESMTPS id v9sm6856547wah.36.2009.06.26.17.44.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 26 Jun 2009 17:44:23 -0700 (PDT) Message-ID: <4A456B65.6070309@lerdorf.com> Date: Fri, 26 Jun 2009 17:44:21 -0700 User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) MIME-Version: 1.0 To: Ilia Alshanetsky CC: PHP internals , Scott MacVicar , Pierre Joye , Lukas Smith References: <9A46F4B8-E64A-4C3C-B2A5-FC354A3EB71D@pooteeweet.org> <0C2F23C2-D188-4938-B44C-4ED166B934CE@macvicar.net> <4A451D6A.8090102@lerdorf.com> <4A454583.9000801@lerdorf.com> <901C4626-24FD-46A6-A116-7B9502FCD67D@prohost.org> <4A4566BD.4000109@lerdorf.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] post 5.3.0 development From: rasmus@lerdorf.com (Rasmus Lerdorf) Ilia Alshanetsky wrote: > After some conversations with Rasmus on IRC i've come up with the > following patch: > > http://ilia.ws/patch/curl.txt > > This basically forces flush() on the header & output streams right after > curl_exec(), this ensures that the data retrieved by curl is synched to > disk. The patch is also self contained to curl so no external elements > are affected by the patch. This looks good to me. It means 5.2.9 code will keep working. The only slight behavioural change where the fp is now flushed before the fclose/curl_close, but if anybody relied on a read at that point not returning the last buffer, they deserve what they get. This needs to go into all branches and let's re-tag and re-package 5.3 with this, Andrei's calloc fix, and the UPGRADING fixes. -Rasmus