Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44505 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80140 invoked from network); 26 Jun 2009 23:58:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Jun 2009 23:58:19 -0000 Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.221.198 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.221.198 mail-qy0-f198.google.com Received: from [209.85.221.198] ([209.85.221.198:39697] helo=mail-qy0-f198.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F9/AD-08868-B90654A4 for ; Fri, 26 Jun 2009 19:58:19 -0400 Received: by qyk36 with SMTP id 36so3574039qyk.29 for ; Fri, 26 Jun 2009 16:58:16 -0700 (PDT) Received: by 10.224.37.141 with SMTP id x13mr95839qad.386.1246060696341; Fri, 26 Jun 2009 16:58:16 -0700 (PDT) Received: from ?192.168.1.132? (CPE0018f8c0ee69-CM000f9f7d6664.cpe.net.cable.rogers.com [99.238.11.214]) by mx.google.com with ESMTPS id 5sm8610355qwg.25.2009.06.26.16.58.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 26 Jun 2009 16:58:15 -0700 (PDT) Cc: Rasmus Lerdorf , Pierre Joye , Lukas Kahwe Smith , PHP internals Message-ID: To: Scott MacVicar In-Reply-To: Content-Type: multipart/mixed; boundary=Apple-Mail-70--681961641 Mime-Version: 1.0 (Apple Message framework v935.3) Date: Fri, 26 Jun 2009 19:58:14 -0400 References: <9A46F4B8-E64A-4C3C-B2A5-FC354A3EB71D@pooteeweet.org> <0C2F23C2-D188-4938-B44C-4ED166B934CE@macvicar.net> <4A451D6A.8090102@lerdorf.com> <4A454583.9000801@lerdorf.com> <901C4626-24FD-46A6-A116-7B9502FCD67D@prohost.org> X-Mailer: Apple Mail (2.935.3) Subject: Re: [PHP-DEV] post 5.3.0 development From: ilia@prohost.org (Ilia Alshanetsky) --Apple-Mail-70--681961641 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Thanks Scott, it helps to save files before quitting ;-) Here is the updated patch. Ilia Alshanetsky --Apple-Mail-70--681961641 Content-Disposition: attachment; filename=curl.txt Content-Type: text/plain; x-unix-mode=0644; name="curl.txt" Content-Transfer-Encoding: 7bit Index: ext/curl/interface.c =================================================================== RCS file: /repository/php-src/ext/curl/interface.c,v retrieving revision 1.62.2.14.2.57 diff -u -p -a -d -r1.62.2.14.2.57 interface.c --- ext/curl/interface.c 15 Jun 2009 12:38:11 -0000 1.62.2.14.2.57 +++ ext/curl/interface.c 26 Jun 2009 23:57:30 -0000 @@ -2093,6 +2093,11 @@ static void _php_curl_close_ex(php_curl efree(ch->header.str); } + /* flush the file handle, so any remaining data is synched to disk */ + if (ch->handlers->write->method == PHP_CURL_FILE && ch->handlers->write->fp) { + fflush(ch->handlers->write->fp); + } + efree(ch->handlers->write); efree(ch->handlers->write_header); efree(ch->handlers->read); --Apple-Mail-70--681961641 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 26-Jun-09, at 7:55 PM, Scott MacVicar wrote: > You have an assignment instead of a comparison there. > > Scott > On 27 Jun 2009, at 00:52, Ilia Alshanetsky wrote: > >> > --Apple-Mail-70--681961641--