Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44500
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.159 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=oeDuAGTGUvuUlCBBk8G8k6gJtJoqDZT+6HCoJTsYzfOFoh8RTh+wiC+ChuRN6NW3Af
         peAJF/j5qkumdTucCgq9N9hcMidiZJ4QAcFHLIFfGxnilcQgyHR6nXel8Afgbe8JbI3H
         6nOoEGexp1vdcZ61/rTTr3VXhZa6ZMY3Nxs0A=
MIME-Version: 1.0
In-Reply-To: <4A454886.9070203@gravitonic.com>
References: <4A453C43.3060806@gravitonic.com> <4A45450D.4060505@zend.com>
	 <4A454886.9070203@gravitonic.com>
Date: Sat, 27 Jun 2009 01:17:00 +0200
Message-ID: <fe05d1540906261617u5b33dd4fv99d9508a601bd883@mail.gmail.com>
To: Andrei Zmievski <andrei@gravitonic.com>
Cc: Stanislav Malyshev <stas@zend.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Memory corruption bug
From: pierre.php@gmail.com (Pierre Joye)

5.2 is already released so you can commit anyway.

For 5.3, I'm not sure (well I am), but wait until Johannes and Lukas
are back online please.

On Sat, Jun 27, 2009 at 12:15 AM, Andrei Zmievski<andrei@gravitonic.com> wrote:
> Stanislav Malyshev wrote:
>>
>> You just did safe_address in _safe_malloc(nmemb, len, 0) which should have
>> called E_ERROR if nmemb*len overflows, so do you need to do it again?
>> Leaving a comment about it wouldn't hurt though :)
>
> Yeah, you're right, but I didn't write the code. :) Regardless, I think this
> fix should go into 5.2/5.3 because calloc() advertises memory clearing as
> part of its API contract.
>
> -Andrei
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org