Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44446
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain darkrainfall.org from 208.97.132.119 cause and error)
Cc: Hannes Magnusson <hannes.magnusson@gmail.com>,
	PHP Development <internals@lists.php.net>
Message-ID: <310F6EAF-6EB4-45D0-BAC4-437C9C764AD0@darkrainfall.org>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
In-Reply-To: <1245786546.3551.6.camel@goldfinger.johannes.nop>
Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v935.3)
Date: Tue, 23 Jun 2009 15:57:33 -0400
References: <7f3ed2c30906230155j12d81566o9b4bee3fe7749e48@mail.gmail.com> <1245786546.3551.6.camel@goldfinger.johannes.nop>
Subject: Re: [PHP-DEV] header_remove() issues (overly aggressive?)
From: gwynne@darkrainfall.org (Gwynne Raskind)

On Jun 23, 2009, at 3:49 PM, Johannes Schl=C3=BCter wrote:
>> While documenting header_remove() I was experimenting a little bit..
>>
>> If an "empty" argument is passed to the function (empty string, null,
>> false,..) the function doesn't do anything, as it checks for
>> ZEND_NUM_ARGS() rather then the length of string.. thats a doc issue
>> or bug?
> I'd say it's ok, "remove the header with the name ''." That's what it
> does.

A header named '' isn't valid in HTTP 1.0 or 1.1 anyway; this is an =20
error case IMO.

>> Second, it removes even the X-Powered-By header, is that expected?

Useful for people who don't have control over their expose_php =20
setting...

>> Third, it removes session and even cookie headers..
>
>> Is that really expected? Just add a big fat warning on the doc page?
> It removes all. Should be ok, too, removing the session cookie might
> even be considered a "good" feature by some.

Including me! ;)

-- Gwynne