Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44445
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 83.243.58.134 cause and error)
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: PHP Development <internals@lists.php.net>
In-Reply-To: <7f3ed2c30906230155j12d81566o9b4bee3fe7749e48@mail.gmail.com>
References: <7f3ed2c30906230155j12d81566o9b4bee3fe7749e48@mail.gmail.com>
Content-Type: text/plain
Date: Tue, 23 Jun 2009 21:49:06 +0200
Message-ID: <1245786546.3551.6.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] header_remove() issues (overly aggressive?)
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Tue, 2009-06-23 at 10:55 +0200, Hannes Magnusson wrote:
> While documenting header_remove() I was experimenting a little bit..
> 
> If an "empty" argument is passed to the function (empty string, null,
> false,..) the function doesn't do anything, as it checks for
> ZEND_NUM_ARGS() rather then the length of string.. thats a doc issue
> or bug?

I'd say it's ok, "remove the header with the name ''." That's what it
does.

> Second, it removes even the X-Powered-By header, is that expected?
> 
> Third, it removes session and even cookie headers..

> Is that really expected? Just add a big fat warning on the doc page?

It removes all. Should be ok, too, removing the session cookie might
even be considered a "good" feature by some.

Jut my personal opinion though.

johannes