Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44433
Return-Path: <hannes.magnusson@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 52623 invoked from network); 23 Jun 2009 08:55:34 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Jun 2009 08:55:34 -0000
Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass; domainkeys=bad
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.152 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: hannes.magnusson@gmail.com
X-Host-Fingerprint: 72.14.220.152 fg-out-1718.google.com  
Received: from [72.14.220.152] ([72.14.220.152:53955] helo=fg-out-1718.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 24/76-36467-588904A4 for <internals@lists.php.net>; Tue, 23 Jun 2009 04:55:34 -0400
Received: by fg-out-1718.google.com with SMTP id 16so1220292fgg.0
        for <internals@lists.php.net>; Tue, 23 Jun 2009 01:55:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:date:message-id:subject
         :from:to:content-type:content-transfer-encoding;
        bh=g545YA4JjA3/yEUpi6V29zohBfEEAPD7vy/pmDsYhnQ=;
        b=TssAn30OOgpqZDZdkhKwN6B9PO+ZICShp3lCKUi7IdoL6OHGJXxuweqoO81xgaIbEP
         xJL2Nwfr6IFgqI833psZVVRo9JiZ+T3B6GFE+O3UWjMkDag9rbtJaMJJBaltoIJP4T8g
         U6mJ+yLuj4vrclVSqwcVXHYTP2vo4YIijkWu4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=FzprD44ZPUZ7DPylt6Qmu/jO7ZEbFLCjwGnYXlkJCG7AAP/XmCC9QqCmday3Z3K0i3
         NGvRMAgL+mlKbJgLU1Ae5vld8jW4pK74sChP39REr0sh/WApBJbWmPzgqqbofjgYO4kQ
         znfuP48eIb5pfAQQUCZWREUDTAv5TbLDLGw5s=
MIME-Version: 1.0
Received: by 10.86.23.20 with SMTP id 20mr7943007fgw.17.1245747330999; Tue, 23 
	Jun 2009 01:55:30 -0700 (PDT)
Date: Tue, 23 Jun 2009 10:55:30 +0200
Message-ID: <7f3ed2c30906230155j12d81566o9b4bee3fe7749e48@mail.gmail.com>
To: PHP Development <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: header_remove() issues (overly aggressive?)
From: hannes.magnusson@gmail.com (Hannes Magnusson)

Hi all

While documenting header_remove() I was experimenting a little bit..

If an "empty" argument is passed to the function (empty string, null,
false,..) the function doesn't do anything, as it checks for
ZEND_NUM_ARGS() rather then the length of string.. thats a doc issue
or bug?

Second, it removes even the X-Powered-By header, is that expected?

Third, it removes session and even cookie headers..

bjori@jessica:/usr/src/php/5.3$ sapi/cgi/php-cgi
<?php
session_start();
session_write_close();
X-Powered-By: PHP/5.3.0RC5-dev
Set-Cookie: PHPSESSID=b8g31to001mdfoqq6gg1c90ru2; path=/
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Content-type: text/html

bjori@jessica:/usr/src/php/5.3$ sapi/cgi/php-cgi
<?php
session_start();
session_write_close();
header_remove();
Content-type: text/html


Is that really expected? Just add a big fat warning on the doc page?

-Hannes