Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44351 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48586 invoked from network); 18 Jun 2009 13:39:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Jun 2009 13:39:52 -0000 Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.219.214 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.219.214 mail-ew0-f214.google.com Received: from [209.85.219.214] ([209.85.219.214:52101] helo=mail-ew0-f214.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 20/0B-33923-7A34A3A4 for ; Thu, 18 Jun 2009 09:39:52 -0400 Received: by ewy10 with SMTP id 10so1436195ewy.23 for ; Thu, 18 Jun 2009 06:39:48 -0700 (PDT) Received: by 10.211.201.7 with SMTP id d7mr1866593ebq.0.1245332388717; Thu, 18 Jun 2009 06:39:48 -0700 (PDT) Received: from ?192.168.1.169? (TOROON63-1176059019.sdsl.bell.ca [70.25.60.139]) by mx.google.com with ESMTPS id 5sm90457eyf.58.2009.06.18.06.39.44 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 18 Jun 2009 06:39:47 -0700 (PDT) Cc: internals Mailing List , dmitry@php.net, tony2001@php.net Message-ID: <9F4E5000-CC3A-420D-B054-AEDCE6DE1B81@prohost.org> To: Scott MacVicar In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 18 Jun 2009 09:39:37 -0400 References: X-Mailer: Apple Mail (2.935.3) Subject: Re: [PHP-DEV] PHP Bug 48215 From: ilia@prohost.org (Ilia Alshanetsky) The patch looks fine to me. Ilia Alshanetsky On 17-Jun-09, at 11:43 AM, Scott MacVicar wrote: > Hey, > > Bug 48215 was a BC break from the previous 5.2 behaviour, it stemmed > from a change for bug #39127. > > class a { function a($arg='') { echo $arg; } } > class b extends a {} > > $b = new b; > $b->b('foo'); > $b->__construct('foo'); > > This prints out an error in 5.3 which is fine, the unexpected change > was that if a __construct() method was actually defined as well as a > method that matched the class name it would alias the parent method > to the constructor. The test is attached in the patch. > > Just sending off to internals first since we're so late in the RC > stage. > > Scott > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php