Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44350
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender)
To: Scott MacVicar <scott@macvicar.net>
Cc: internals Mailing List <internals@lists.php.net>, dmitry@php.net,  tony2001@php.net
In-Reply-To: <A5F0402B-0264-4089-8C12-07366E274FCB@macvicar.net>
References: <A5F0402B-0264-4089-8C12-07366E274FCB@macvicar.net>
Content-Type: text/plain
Date: Thu, 18 Jun 2009 15:01:27 +0200
Message-ID: <1245330087.7355.60.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP Bug 48215
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Wed, 2009-06-17 at 16:43 +0100, Scott MacVicar wrote:
> Hey,
> 
> Bug 48215 was a BC break from the previous 5.2 behaviour, it stemmed  
> from a change for bug #39127.

this should be fixed in 5.3, for me the patch looks fine, and should be
committed. While I'd be in favor on a short review by somebody else
(Dmitry?)

Thanks,
johannes

> class a { function a($arg='') { echo $arg; } }
> class b extends a {}
> 
> $b = new b;
> $b->b('foo');
> $b->__construct('foo');
> 
> This prints out an error in 5.3 which is fine, the unexpected change  
> was that if a __construct() method was actually defined as well as a  
> method that matched the class name it would alias the parent method to  
> the constructor. The test is attached in the patch.
> 
> Just sending off to internals first since we're so late in the RC stage.
> 
> Scott
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php