Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44329 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 41640 invoked from network); 16 Jun 2009 22:13:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jun 2009 22:13:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 88.198.8.16 bigtime.backendmedia.com Linux 2.6 Received: from [88.198.8.16] ([88.198.8.16:41821] helo=bigtime.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 88/E0-35766-CF8183A4 for ; Tue, 16 Jun 2009 18:13:17 -0400 Received: from localhost (unknown [127.0.0.1]) by bigtime.backendmedia.com (Postfix) with ESMTP id 68C961EBC01A; Tue, 16 Jun 2009 22:15:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from bigtime.backendmedia.com ([127.0.0.1]) by localhost (bigtime.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YzDUItMukYsk; Wed, 17 Jun 2009 00:15:58 +0200 (CEST) Received: from [192.168.0.151] (84-72-88-166.dclient.hispeed.ch [84.72.88.166]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by bigtime.backendmedia.com (Postfix) with ESMTP id 530DC1EBC015; Wed, 17 Jun 2009 00:15:52 +0200 (CEST) Cc: Greg Beaver , Hannes Magnusson , PHP Internals List Message-ID: To: Pierre Joye In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Wed, 17 Jun 2009 00:13:07 +0200 References: <4A370CB2.9060602@chiaraquartet.net> <7f3ed2c30906160333s3dda0831q5a2fed430fcfbd38@mail.gmail.com> <4A3783BA.6030008@gmail.com> <20090616140033.GA27274@panix.com> <4A37D8ED.3080308@chiaraquartet.net> <50E0C0BF-13EC-4C31-B66D-FC0F54417227@pooteeweet.org> <4A37EB7D.7010209@chiaraquartet.net> <7f3ed2c30906161205t2ff47bd7hfc9e51292fef6fb3@mail.gmail.com> <4A37EE13.2020906@chiaraquartet.net> X-Mailer: Apple Mail (2.935.3) Subject: Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED From: mls@pooteeweet.org (Lukas Kahwe Smith) Hi, This seems like a trivial change from the implementation side, so I am not worried about changing this for the "better" even after RC4 (given proper documentation. So here are the choices I see: 1) stay as is .. aka defaults to on while not emiting an E_DEPRECATED, do emit E_DEPRECATED when using the setter 2) as per Zeev, leave the default as is and change things when using the setter as follows: "emit E_DEPRECATED in case of true and nothing in case of false; For 6 - emit an error for true and nothing for false." (so he is also suggesting to revert the removal of the setter in PHP6) 3) stay as is .. aka defaults to on while not emiting an E_DEPRECATED, but do not emit E_DEPRECATED when using the setter to disable 4) change the default to off, for the rest stay as is A few notes: First up we are late in the RC stage. Also E_DEPRECATED is a "checker tool" you enable temporarily during development. I expect most people to use a php.ini supplied by whatever distro they are using or simply update their current php.ini, in which case they are most likely setting a value for this setting explicitly, which should cause and E_DEPRECATED if enabling this feature. I am also not sure which if the other settings that we are removing in PHP6 are also on by default, but obviously if we change something here, we are opening pandora's box to those as well: - define_syslog_variables - register_globals - register_long_arrays - safe_mode Please keep things as concise as possible when you reply. regards, Lukas