Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44318
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.155 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=AnQt3xmTuQMGdWHQ0DIpDBHuJcSVliWrM/nC5V5R6Rn8jCdoGhx5ifcjzUKsQKyxQu
         ggL4RT04Er/9VJSQo/tWO3H6oadmi4jjI6msH3WaPlI5umpPBRBNNAPY73aNZNHNpT7M
         PDSXoB54oiyzLPKCY5ZWk7WAvvmW1Op7BkVqQ=
MIME-Version: 1.0
In-Reply-To: <50E0C0BF-13EC-4C31-B66D-FC0F54417227@pooteeweet.org>
References: <4A370CB2.9060602@chiaraquartet.net>
	 <fe05d1540906160109g10075b6fkee52b7fe649dcb25@mail.gmail.com>
	 <7f3ed2c30906160320m4625ae89i1b85c036ba798de0@mail.gmail.com>
	 <4A3772DD.2010604@daevel.net>
	 <7f3ed2c30906160333s3dda0831q5a2fed430fcfbd38@mail.gmail.com>
	 <fe05d1540906160347m4e0d5936x8707c6f274ece268@mail.gmail.com>
	 <4A3783BA.6030008@gmail.com> <20090616140033.GA27274@panix.com>
	 <4A37D8ED.3080308@chiaraquartet.net>
	 <50E0C0BF-13EC-4C31-B66D-FC0F54417227@pooteeweet.org>
Date: Tue, 16 Jun 2009 20:57:42 +0200
Message-ID: <fe05d1540906161157ib0f0f0ewfb7a771c8fe3e826@mail.gmail.com>
To: Lukas Kahwe Smith <mls@pooteeweet.org>
Cc: Greg Beaver <greg@chiaraquartet.net>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED
From: pierre.php@gmail.com (Pierre Joye)

hi Lukas,

On Tue, Jun 16, 2009 at 8:49 PM, Lukas Kahwe Smith<mls@pooteeweet.org> wrot=
e:
>
> On 16.06.2009, at 19:39, Greg Beaver wrote:
>
>> Daniel Convissor wrote:
>>>
>>> Folks:
>>>
>>>> I propose the following behavior: "Throw a deprecated warning unless
>>>> magic quotes are currently enabled and the
>>>> parameter is to disable them".
>>>
>>> The function is going away. =A0A deprecated warning is necessary to ale=
rt
>>> people of this fact, no matter how the function is used.
>>
>> I'm sorry, but there is a bug here.
>>
>> On my system, magic_quotes_gpc is enabled by default, and no
>> E_DEPRECATED warning is thrown.
>>
>> Check it out. =A0Compile a vanilla PHP 5.3, and run php -n -i |grep magi=
c
>>
>> It's probably an oversight, but if it is intentional, we can't punish
>> people for disabling something that is enabled by default.
>
>
> 1) its not about "punishing", its about alerting people that they are
> relying on stuff that will go away
> 2) E_DEPRECATE is for development only and only as a check you enable now
> and then
> 3) its off in both of the php.ini's we will ship with 5.3

What Greg meant is:
C:\Users\pierre\Documents\test\php530rc3tsvc9x86>php -n -i |find "magic"
magic_quotes_gpc =3D> On =3D> On
magic_quotes_runtime =3D> Off =3D> Off
magic_quotes_sybase =3D> Off =3D> Off

magic_quotes_gpc should be off by default (default value).

I can commit the change now (as asked on IRC). But Lukas raises the
question about changing default values in minor releases. As they are
off in both php.ini, there is no reason to keep it On by default. Any
opposition before I fix it?

Cheers,
--=20
Pierre

http://blog.thepimp.net | http://www.libgd.org