Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44262
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 209.85.222.204 cause and error)
Message-ID: <4A33D8B8.30203@chiaraquartet.net>
Date: Sat, 13 Jun 2009 11:50:00 -0500
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807)
MIME-Version: 1.0
To: Christian Seiler <chris_se@gmx.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
References: <4A3343A1.4060701@chiaraquartet.net> <4A338AC9.1090100@gmx.net>
In-Reply-To: <4A338AC9.1090100@gmx.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] bug 48541 - critical for PHP 5.3
From: greg@chiaraquartet.net (Greg Beaver)

Christian Seiler wrote:
> Hi Greg,
> 
>> I can do it if someone can answer this question: how do closures
>> uniquely identify themselves?  spl_autoload_register is mistakenly
>> treating all closures as if they were a single copy of the static method
>> "Closure::__invoke", and so only the first registered closure is ever
>> called (plus it leaks the other closures at shutdown).  If the system
>> can be made to better identify the closure, then spl_autoload_register
>> can use that (and also properly free the refcount on a dupe).
> 
> A closure can only be uniquely identified by the object storage id the
> object has. You cannot assume any identity with regard to, for example,
> file name and line where it was defined, since one could imagine the
> following:
> 
> foreach ($dirs as $dir) {
>   spl_autoload_register (function ($class) use ($dir) {
>      include $dir.'/'.$class.'.php';
>   });
> }
> 
> (or something like it)
> 
> If nobody else does it I'll fix this later today.

Hi,

Thanks Christian, I've got a patch and a test I'm about to commit, would
be great if you can review it.

Thanks,
Greg