Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44208 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48840 invoked from network); 8 Jun 2009 20:09:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jun 2009 20:09:57 -0000 Authentication-Results: pb1.pair.com header.from=solar@openwall.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=solar@openwall.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain openwall.com designates 195.42.179.200 as permitted sender) X-PHP-List-Original-Sender: solar@openwall.com X-Host-Fingerprint: 195.42.179.200 mother.openwall.net Received: from [195.42.179.200] ([195.42.179.200:50670] helo=mother.openwall.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 83/CC-05173-4107D2A4 for ; Mon, 08 Jun 2009 16:09:57 -0400 Received: (qmail 10111 invoked from network); 8 Jun 2009 20:09:52 -0000 Received: from localhost (HELO pvt.openwall.com) (127.0.0.1) by localhost with SMTP; 8 Jun 2009 20:09:52 -0000 Received: by pvt.openwall.com (Postfix, from userid 503) id 1EBC92FD12; Tue, 9 Jun 2009 00:09:50 +0400 (MSD) Date: Tue, 9 Jun 2009 00:09:50 +0400 To: Pierre Joye Cc: PHP Internals List Message-ID: <20090608200950.GA3862@openwall.com> References: <20090607160019.GA30041@openwall.com> <20090608151115.GA2328@openwall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Subject: Re: ext/standard/crypt_blowfish.c From: solar@openwall.com (Solar Designer) On Mon, Jun 08, 2009 at 08:22:15PM +0200, Pierre Joye wrote: > Sadly I do not have the time yet to fix the behavior (remove the > workaround/BC hack or the on error behavior). If you like to (or have > the time to :), you can five it a try, that will be very helpful. Or I > can work on that next week, at the soonest. I'm afraid I don't have time for much more than commenting on my code, which I feel somewhat responsible to do. Next week sounds fine to me. As to removing "the workaround/BC hack", I think this amounts to removing these lines: + if (tmp == '$') break; \ ... + while (dptr < end) + *dptr++ = 0; + (as seen in the diff I had posted). The test in crypt.phpt looks fine to me (that is, it tests for the correct behavior already). Thanks, Alexander