Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44204 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23717 invoked from network); 8 Jun 2009 13:11:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jun 2009 13:11:08 -0000 Authentication-Results: pb1.pair.com header.from=patrick.allaert@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=patrick.allaert@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.220 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: patrick.allaert@gmail.com X-Host-Fingerprint: 209.85.220.220 mail-fx0-f220.google.com Received: from [209.85.220.220] ([209.85.220.220:38994] helo=mail-fx0-f220.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 37/23-05173-BED0D2A4 for ; Mon, 08 Jun 2009 09:11:07 -0400 Received: by fxm20 with SMTP id 20so3385789fxm.23 for ; Mon, 08 Jun 2009 06:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=XrplBRX/KfpYWoH0rHpEGmkI9MWZpnY/1mLBO1H8DHI=; b=FqRF0yvf9z6g32liZ/1IF4bmQUTmnB/waemvUx3bO1eFLOm3ypdY+NHWPRd+CCjYIU Uq5Y9ryfxkfV02W8ed95JMJ8F9hz2VCe2ckXRkYvwEKhIP5wmTN/+AtRxUMgzmhljzoQ VFjofo+Gduv9KG/hq++ACGf4hagqO+OYkrehg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; b=lBEf3AfCsJFvw0lzFXYnw/QuOiSITuxi7GQjeJZzyNmvMve7fUfZpaVAwjhdCAeELJ OEjKGMAqPCsrr66JrLPBm4ybggLFp32L3TAU5GtUdzAeHDDlv9WO6/6B1LIxQ2PYZ+/0 YxeI+A816eX7GRLIkzhZ4NlLOkogUizJNGvhQ= MIME-Version: 1.0 Sender: patrick.allaert@gmail.com Received: by 10.239.132.205 with SMTP id 13mr495469hbs.168.1244466664297; Mon, 08 Jun 2009 06:11:04 -0700 (PDT) Date: Mon, 8 Jun 2009 15:11:04 +0200 X-Google-Sender-Auth: 86232e0ccfe34d5b Message-ID: To: PHP Development Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [PATCH] ext/ldap: PHP 6 & bug #48441 From: patrickallaert@php.net (Patrick ALLAERT) Hello list, I'd like to adapt ext/ldap for (1) PHP 6 (2) bug #48441. I also have at my disposal more than 80 phpt tests files for ext/ldap that I will commit too. In order to address this issues I'd like to have your review on the following patches before I commit them: (a) Refactoring of php_ldap_do_search() which also simplifies (b) and (c): - Common cleanup section at the end of the function to avoid duplicating cleaning logic. - Logic specific to parallel/non-parallel search implemented inside *one* "if (parallel search) {...} else {...}" block. Patch: http://87.98.252.90/01-ldap_refactor.patch.txt http://87.98.252.90/01-ldap_refactor.patch.ignoreSpaceChanges.txt (diff -bB version, easier for review-only) (b) Converting ext/ldap to work with PHP 6: Patch: http://87.98.252.90/02-ldap_unicode.patch.txt (c) Fixing #48441: Patch: http://87.98.252.90/03-ldap_bug48441.patch.txt All of them should be committed to HEAD (a) and (c) should be committed in addition to PHP_5_3 and PHP_5_2 (with adaptations). You can test them with: http://testfest.php.net/repos/testfest/BelgiumUG/ext/ldap/tests/ Thanks for your feedback :) Cheers, -- Patrick Allaert --- http://patrickallaert.blogspot.com/ http://code.google.com/p/peclapm/ - Alternative PHP Monitor