Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44145 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74534 invoked from network); 4 Jun 2009 02:55:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Jun 2009 02:55:46 -0000 Authentication-Results: pb1.pair.com smtp.mail=php_lists@realplain.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=php_lists@realplain.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error) X-PHP-List-Original-Sender: php_lists@realplain.com X-Host-Fingerprint: 209.151.69.1 liberty.vosn.net Linux 2.4/2.6 Received: from [209.151.69.1] ([209.151.69.1:56836] helo=liberty.vosn.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7D/73-54737-0B7372A4 for ; Wed, 03 Jun 2009 22:55:46 -0400 Received: from 75-120-255-76.dyn.centurytel.net ([75.120.255.76]:64980 helo=pc1) by liberty.vosn.net with smtp (Exim 4.69) (envelope-from ) id 1MC37F-00007a-2g; Wed, 03 Jun 2009 20:55:41 -0600 Message-ID: <657AA7C86E5140EF904DC17B11B8F78D@pc1> To: , "Andrei Zmievski" References: <7435CCB5C8694BDCAAC90C165570A3E1@pc1> <4A26DA21.1030703@gravitonic.com> Date: Wed, 3 Jun 2009 21:55:38 -0500 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5512 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - liberty.vosn.net X-AntiAbuse: Original Domain - lists.php.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - realplain.com Subject: Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe From: php_lists@realplain.com ("Matt Wilmas") Hi Andrei, all, ----- Original Message ----- From: "Andrei Zmievski" Sent: Wednesday, June 03, 2009 > Matt Wilmas wrote: >> [...] >> Patches: >> http://realplain.com/php/binary_eval_string.diff >> http://realplain.com/php/binary_eval_string_5_3.diff >> >> Can they be applied? (Also a small optimization by eliminating strlen() >> usage.) May want to verify the ext/interbase change. > > Yes, apply them (though I didn't verify the interbase patch). All right. :-) >> I noticed there are several zend_eval_string() references in PECL sources >> [1], which would be a problem after adding a string length parameter... >> How is that handled? Should the updated function be eval_stringL instead >> and add macros for compatibility? > > I'd prefer that. It seems the TSRMLS params would be an issue with macros (or am I not thinking right?), so I just used wrapper functions... Patches are updated -- didn't check changes yet, but hopefully I didn't miss anything. > -Andrei Thanks, Matt