Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44138 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19792 invoked from network); 3 Jun 2009 20:57:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jun 2009 20:57:04 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 83.243.58.134 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 83.243.58.134 mailout2.netbeat.de Linux 2.6 Received: from [83.243.58.134] ([83.243.58.134:51117] helo=mailout2.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 66/CA-19828-D93E62A4 for ; Wed, 03 Jun 2009 16:57:02 -0400 Received: (qmail 12881 invoked by uid 89); 3 Jun 2009 21:28:17 -0000 Received: from unknown (HELO ?192.168.1.102?) (johannes%schlueters.de@62.216.215.239) by mailout2.netbeat.de with ESMTPA; 3 Jun 2009 21:28:17 -0000 To: Matt Wilmas Cc: internals@lists.php.net In-Reply-To: <7435CCB5C8694BDCAAC90C165570A3E1@pc1> References: <7435CCB5C8694BDCAAC90C165570A3E1@pc1> Content-Type: text/plain Date: Wed, 03 Jun 2009 22:56:45 +0200 Message-ID: <1244062605.5852.1.camel@goldfinger> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Wed, 2009-06-03 at 13:45 -0500, Matt Wilmas wrote: > I noticed there are several zend_eval_string() references in PECL sources > [1], which would be a problem after adding a string length parameter... How > is that handled? Should the updated function be eval_stringL instead and > add macros for compatibility? typical naming would be using eval_string_ex for the version with the length, but didn't look into it and will be offline till tuesday. Bu if others review and agree it is a good thing to change. (incl 5.3) johannes