Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44126
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.216.187 cause and error)
Message-ID: <4A258BE5.3080409@lerdorf.com>
Date: Tue, 02 Jun 2009 13:30:29 -0700
User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
MIME-Version: 1.0
To: Andrei Zmievski <andrei@gravitonic.com>
CC: PHP internals <internals@lists.php.net>
References: <4A245810.20503@gravitonic.com> <4A258942.6010900@gravitonic.com>
In-Reply-To: <4A258942.6010900@gravitonic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: ext/filter and rfc1867 problem
From: rasmus@lerdorf.com (Rasmus Lerdorf)

As far as I remember that is because php_sapi_filter() does the variable
registration for those cases, so it shouldn't be done in rfc1867.c

Andrei Zmievski wrote:
> Does anyone have any idea what I'm talking about here? Derick? Rasmus?
> Pierre? Bueller?
> 
> Andrei Zmievski wrote:
>> I ran into an issue today that seems to be a genuine bug.
>>
>> In rfc1867.c there is code like this:
>>
>>   if (sapi_module.input_filter(PARSE_POST, param, &value, value_len,
>> &new_val_len TSRMLS_CC)) {
>>      /* register the variable */
>>   }
>>
>> The sapi_module.input_filter points to php_sapi_filter(). That return
>> value of that function is based on "retval" variable which defaults to
>> 0 at the top of the function and is set to 1 only when arg is
>> PARSE_STRING. The end result is that it returns 0 and rfc1867 handler
>> never registers the variable. Am I totally missing something or is
>> this a real bug?
>>
>> -Andrei
>