Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43983
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.166 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=EJK0vu6I0JjfcTq9TLx8IypPEea8fCTk7/UFQ6nGlRishbBsV4QtJlbiBVltR1ISIE
         fhoaCOaHRyKCeDcxiTaaeXjY6RdeP3L2Jae6L4Gyq057GIj7DH4SCziFAd2lemUSVDjp
         IqktPQsCX8dK1kd4hkNEjFX4u6zovR1KUQveQ=
MIME-Version: 1.0
In-Reply-To: <4A0D21B4.3000804@daylessday.org>
References: <c6f9c9e70905142031u49874dbifd19fdd340b0c702@mail.gmail.com> 
	<4A0D21B4.3000804@daylessday.org>
Date: Fri, 15 May 2009 07:48:31 -0400
Message-ID: <c6f9c9e70905150448n608bb928ld831bfcbc06bcde7@mail.gmail.com>
To: Antony Dovgal <tony@daylessday.org>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Segfault while looping through hash table
From: farleyknight@gmail.com (Farley Knight)

On Fri, May 15, 2009 at 4:03 AM, Antony Dovgal <tony@daylessday.org> wrote:
> On 15.05.2009 07:31, Farley Knight wrote:
>> =A0 while (zend_hash_get_current_data(Z_ARRVAL(zhash), (void**)&value)
>> =3D=3D SUCCESS) {
>> =A0 =A0 current++;
>> =A0 =A0 printf("Currently on entry %d\n", current);
>> =A0 =A0 if (zend_hash_move_forward(Z_ARRVAL(zhash)) =3D=3D SUCCESS)
>> =A0 =A0 =A0 printf("Done moving hash forward. Result was successful\n");
>> =A0 =A0 else
>> =A0 =A0 =A0 printf("Done moving hash forward. Result was a failure\n");
>> =A0 }
>
> What's the point of this if() ?
> You continue reading the values even if move_forward() fails (i.e. the en=
d is reached).

I threw that in for debugging purposes.. So it's completely useless otherwi=
se :)

>
> --
> Wbr,
> Antony Dovgal
>

- Farley