Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43925 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76346 invoked from network); 14 May 2009 13:44:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 May 2009 13:44:59 -0000 Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.71 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 204.13.248.71 mho-01-ewr.mailhop.org Received: from [204.13.248.71] ([204.13.248.71:56285] helo=mho-01-ewr.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D9/8D-27038-8502C0A4 for ; Thu, 14 May 2009 09:44:58 -0400 Received: from cs181029147.pp.htv.fi ([82.181.29.147] helo=[127.0.0.1]) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1M4bF0-000CgP-BT; Thu, 14 May 2009 13:44:54 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 82.181.29.147 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/po2KnWZZ6A516vZG25+i+cB4dNx4s2LY= Message-ID: <4A0C2055.4070603@sci.fi> Date: Thu, 14 May 2009 16:44:53 +0300 Reply-To: jani.taskinen@iki.fi User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Tim Starling CC: internals Mailing List References: <4A0B7B23.1080506@wikimedia.org> In-Reply-To: <4A0B7B23.1080506@wikimedia.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Bug #48256 readline crash From: jani.taskinen@sci.fi (Jani Taskinen) Tim Starling kirjoitti: > The readline extension links both libreadline and libhistory. This is > unnecessary, and inspection of the readline example programs since > version 2.0 implies that it has always been unnecessary. Both libraries > include history.o, so linking to both gives you two copies of that module. I'd be quite worried about this what you mentioned in that report: "The libraries are loaded in the problematic order in Ubuntu 9.04, previous versions of Ubuntu appeared to work. WHY does newer Ubuntu load some lib before the other? I'd find that out to prevent other similar problems. > The bug occurs when, due to operating system vagaries, libhistory loads > before libreadline. This causes PHP's readline_add_history() to add > history entries to libhistory's copy of the_history. Then when > readline() is called, libreadline attempts to read the other copy of > the_history. The result is a null pointer dereference in libreadline's > previous_history() function. > > The solution is to remove all references to libhistory in > ext/readline/config.m4. I have patched this in and tested it. Apparently there are other OSes with some problems as well with it. I removed the stuff in CVS now. > This bug was closed as "bogus" on bugs.php.net due to some temporary > short-circuit in the mind of a bug tracker admin. It's totally PHP's > fault and there's nothing any distro can do to fix it. Heh..I have short temper but definately no short-circuits. Rather "long cabling" maybe. :D --Jani