Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43863
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.159 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=xMgHDgUpEX7v/5fTrvVp+mjMhyHghiePEzaCjzXktelUl8dgEyexGRZtIIwgjcqCNp
         Uu30wssTd5VUB+vhpPH9lF6xAyOk810rBwTeev1JlQyoGMsK0BNizY4PmFf755F/GZL4
         YwLyj6slRSx07wXxld6ktDeNv6YwZ8IU+iQM4=
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <4A01A9C3.5010108@smashlabs.com>
References: <4A01A9C3.5010108@smashlabs.com>
Date: Wed, 6 May 2009 17:35:46 +0200
Message-ID: <e666c3890905060835q50f99e5coaa59ab2158165904@mail.gmail.com>
To: Ralph Schindler <ralph@smashlabs.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RecursiveFilterItrator possible issues with inheritance
From: webmaster@colder.ch (Etienne Kneuss)

Hello,

On Wed, May 6, 2009 at 5:16 PM, Ralph Schindler <ralph@smashlabs.com> wrote:
> Hi all,
>
> I'd like to confirm something as a bug and/or design issue.

This is a bug, could you please report it and assign it to me ?

Thanks,

>
> Currently, its difficult to extend RecursiveFilterIterator() with additional
> __construct() arguments (for configuring its behavior).  The reason its
> difficult is b/c when getChildren() is called, a new instance of the RFI is
> created (only way you'd know this is if you look into the source of RFI).
>
> Ideally, this code would work:
>
>
> $rArray = array('a' => array('ab', 'ac', 'ad' => array('ada', 'adc')), 'b'
> => array('bb', 'bc'));
>
> $ri = new RecursiveArrayIterator($rArray);
> $filter = new MyRFI($ri, 'argument');
> $iterator = new RecursiveIteratorIterator($filter);
>
> foreach ($iterator as $key => $item) {
>    echo $key . ' - ' . $item . PHP_EOL;
> }
>
> class MyRFI extends RecursiveFilterIterator
> {
>    protected $_otherArg = null;
>
>    public function __construct($iterator, $otherArg = null)
>    {
>        $r = new ReflectionClass($this);
>        $this->_otherArg = $otherArg;
>        parent::__construct($iterator);
>    }
>
>    public function accept()
>    {
>        echo ($this->_otherArg) ? 'Arg Present' : 'Arg NOT Present';
>        echo PHP_EOL;
>        return true;
>    }
>
>
> The current output would be:
>
>
> ~/tmp/test-rii-filter$ php test-rii-problem.php
> Arg Present
> Arg NOT Present
> 0 - ab
> Arg NOT Present
> 1 - ac
> Arg NOT Present
> Arg NOT Present
> 0 - ada
> Arg NOT Present
> 1 - adc
> Arg Present
> Arg NOT Present
> 0 - bb
> Arg NOT Present
> 1 - bc
>
>
> The ideal output would be:
>
> Arg Present
> Arg Present
> 0 - ab
> Arg Present
> 1 - ac
> Arg Present
> Arg Present
> 0 - ada
> Arg Present
> 1 - adc
> Arg Present
> Arg Present
> 0 - bb
> Arg Present
> 1 - bc
>
>
>
>
> The only proposed change I could would be to make the getChildren() inside
> of RecursiveFilterIterator use clone & add a method called setIterator()
> instead of Reflection::newInstance($iterator)
>
> Is this possible? Or is extending and overriding getChildren() the best
> strategy here?
>
> Reason I post is b/c it seems like using clone/setIterator() would
> facilitate better inheritance / better polymorphism.  And since the
> implementation is in the extension, the typical developer would generally
> not understand how getChildren() really works under the hood.
>
> Thanks,
> Ralph
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal