Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43828
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender)
Message-ID: <49FE9BDA.3020603@zend.com>
Date: Mon, 04 May 2009 11:40:10 +0400
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Matt Wilmas <php_lists@realplain.com>
CC: internals@lists.php.net, Nuno Lopes <nlopess@php.net>, 
 Lukas Kahwe Smith <mls@pooteeweet.org>,
 shire@php.net
References: <6604D94D40FD465F992144110B075BB5@pc1> <E17F0EFAC0F847C994EBDA6D020E52BF@PC3EE1F19287> <9D5D4CBF-5CB1-47EC-81F4-59E3C48EEEEF@pooteeweet.org> <C8E7CB69316B42D1B8BB5ED78408088D@PC3EE1F19287> <B06CC8E0A66F4959B3BFC4AA0698223D@pc1>
In-Reply-To: <B06CC8E0A66F4959B3BFC4AA0698223D@pc1>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Scanner "diet" with fixes, etc.
From: dmitry@zend.com (Dmitry Stogov)

Hi Matt,

I wasn't able to look into all details of the patch, but in general I 
like it, as it fixes bugs and makes scanner smaller. I think you can 
commit it.

Although this patch doesn't fix the EOF handling related to mmap().

Thanks. Dmitry.

Matt Wilmas wrote:
> Hi guys,
> 
> ----- Original Message -----
> From: "Nuno Lopes"
> Sent: Thursday, April 30, 2009
> 
>>>> The patch looks generally ok. However I'll need a few more days to 
>>>> review it carefully and throughly. (you can merge it in the 
>>>> meantime  if you want).
>>>> I'm just slighty concern with the amount of parsing we are now 
>>>> doing  by hand, and with the possible (local) security bugs we might 
>>>> be introducing..
>>>
>>>
>>> Am I understanding this properly, that this addresses the re2c EOF  
>>> bug? So we have an RC planned for next week (freeze Monday evening).  
>>> Can you get this fixed and released by then as Marcus is unable to 
>>> do  this himself?
>>
>> So this addresses some of the re2c EOF problems, but I don't know if 
>> it addresses all of them or not. I haven't had the time yet for a full 
>> review.
>> Anyway, Matt can surelly comment on this.
> 
> Yes, it addresses the re2c EOF issues for strings and comments, as they 
> were the problem ones that allowed NULL bytes, and scanned past the EOF 
> NULL.  As I said to Dmitry, I'm not sure if it's now possible to remove 
> the temporary mmap() fixes that he wanted removed before the next RC 
> (??), or if there would still be problems with re2c scanning other 
> tokens, even though they can't contain NULLs.  I didn't attempt to make 
> any changes there, since I'm not familiar with what's been done.
> 
> I just wanted to finally send the patch for others to review, and decide 
> what to do, so I won't commit any changes yet in the meantime. :-)
> 
>> Nuno
> 
> 
> - Matt