Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43819 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48484 invoked from network); 30 Apr 2009 20:05:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Apr 2009 20:05:44 -0000 Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.23 as permitted sender) X-PHP-List-Original-Sender: nlopess@php.net X-Host-Fingerprint: 212.55.154.23 relay3.ptmail.sapo.pt Linux 2.4/2.6 Received: from [212.55.154.23] ([212.55.154.23:44922] helo=sapo.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B7/B2-32602-7940AF94 for ; Thu, 30 Apr 2009 16:05:44 -0400 Received: (qmail 29246 invoked from network); 30 Apr 2009 20:04:33 -0000 Received: from unknown (HELO sapo.pt) (10.134.37.162) by relay3 with SMTP; 30 Apr 2009 20:04:33 -0000 Received: (qmail 8512 invoked from network); 30 Apr 2009 20:07:45 -0000 X-AntiVirus: PTMail-AV 0.3-0.92.0 X-Virus-Status: Clean (0.00449 seconds) Received: from unknown (HELO PC3EE1F19287) (nunoplopes@sapo.pt@[93.197.134.14]) (envelope-sender ) by mta12 (qmail-ldap-1.03) with SMTP for ; 30 Apr 2009 20:07:45 -0000 Message-ID: To: "Lukas Kahwe Smith" Cc: "Matt Wilmas" , , "Dmitry Stogov" , References: <6604D94D40FD465F992144110B075BB5@pc1> <9D5D4CBF-5CB1-47EC-81F4-59E3C48EEEEF@pooteeweet.org> Date: Thu, 30 Apr 2009 21:05:39 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5512 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Subject: Re: [PHP-DEV] [PATCH] Scanner "diet" with fixes, etc. From: nlopess@php.net ("Nuno Lopes") >> The patch looks generally ok. However I'll need a few more days to >> review it carefully and throughly. (you can merge it in the meantime if >> you want). >> I'm just slighty concern with the amount of parsing we are now doing by >> hand, and with the possible (local) security bugs we might be >> introducing.. > > > Am I understanding this properly, that this addresses the re2c EOF bug? > So we have an RC planned for next week (freeze Monday evening). Can you > get this fixed and released by then as Marcus is unable to do this > himself? So this addresses some of the re2c EOF problems, but I don't know if it addresses all of them or not. I haven't had the time yet for a full review. Anyway, Matt can surelly comment on this. Nuno