Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43817 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38929 invoked from network); 30 Apr 2009 19:05:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Apr 2009 19:05:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 88.198.8.16 bigtime.backendmedia.com Linux 2.6 Received: from [88.198.8.16] ([88.198.8.16:34882] helo=bigtime.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E3/01-32602-956F9F94 for ; Thu, 30 Apr 2009 15:04:59 -0400 Received: from localhost (unknown [127.0.0.1]) by bigtime.backendmedia.com (Postfix) with ESMTP id 78B0D414405A; Thu, 30 Apr 2009 19:06:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from bigtime.backendmedia.com ([127.0.0.1]) by localhost (bigtime.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yHZCKWVmdhsx; Thu, 30 Apr 2009 21:06:54 +0200 (CEST) Received: from [192.168.0.182] (77-58-147-159.dclient.hispeed.ch [77.58.147.159]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by bigtime.backendmedia.com (Postfix) with ESMTP id 6B5614144009; Thu, 30 Apr 2009 21:06:52 +0200 (CEST) To: Nuno Lopes In-Reply-To: X-Priority: 3 References: <6604D94D40FD465F992144110B075BB5@pc1> Message-ID: <9D5D4CBF-5CB1-47EC-81F4-59E3C48EEEEF@pooteeweet.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Thu, 30 Apr 2009 21:04:49 +0200 Cc: "Matt Wilmas" , , "Dmitry Stogov" , X-Mailer: Apple Mail (2.930.3) Subject: Re: [PHP-DEV] [PATCH] Scanner "diet" with fixes, etc. From: mls@pooteeweet.org (Lukas Kahwe Smith) On 30.04.2009, at 19:18, Nuno Lopes wrote: > The patch looks generally ok. However I'll need a few more days to > review it carefully and throughly. (you can merge it in the meantime > if you want). > I'm just slighty concern with the amount of parsing we are now doing > by hand, and with the possible (local) security bugs we might be > introducing.. Am I understanding this properly, that this addresses the re2c EOF bug? So we have an RC planned for next week (freeze Monday evening). Can you get this fixed and released by then as Marcus is unable to do this himself? regards, Lukas Kahwe Smith mls@pooteeweet.org