Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43814
Return-Path: <tony@daylessday.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 70656 invoked from network); 30 Apr 2009 12:32:44 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Apr 2009 12:32:44 -0000
Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender)
X-PHP-List-Original-Sender: tony@daylessday.org
X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6
Received: from [89.208.40.236] ([89.208.40.236:40807] helo=daylessday.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 32/F4-42998-A6A99F94 for <internals@lists.php.net>; Thu, 30 Apr 2009 08:32:43 -0400
Received: from [192.168.3.47] (unknown [212.42.62.198])
	by daylessday.org (Postfix) with ESMTPSA id 768A6BFA101;
	Thu, 30 Apr 2009 16:32:39 +0400 (MSD)
Message-ID: <49F99A58.9020506@daylessday.org>
Date: Thu, 30 Apr 2009 16:32:24 +0400
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
MIME-Version: 1.0
To: RQuadling@GoogleMail.com
CC: php-dev <internals@lists.php.net>
References: <6604D94D40FD465F992144110B075BB5@pc1> <49F94BC6.5060904@zend.com> 	<49F993FA.2090301@php.net> <10845a340904300515k62fe7dbes4e22b318c61be140@mail.gmail.com>
In-Reply-To: <10845a340904300515k62fe7dbes4e22b318c61be140@mail.gmail.com>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [PATCH] Scanner "diet" with fixes, etc.
From: tony@daylessday.org (Antony Dovgal)

That's what I call 'overquoting'.

On 30.04.2009 16:15, Richard Quadling wrote:
> 2009/4/30 Scott MacVicar <scottmac@php.net>:
>> [^] is a special case to write a portable match any character in re2c.
>>
>> Scott
>>
>> Dmitry Stogov wrote:
>>> Hi Matt,
>>>
>>> Does this patch fix EOF handling issues related to mmap()? (e.g. parsing
>>> of files with size 4096, 8192, ...). Now we have two dirty fixes to
>>> handle them correctly.
>>>
>>> The patch is quite big to understand it quickly. I'll probably take a
>>> look on weekend.
>>>
>>> -ANY_CHAR [^\x00]
>>> +ANY_CHAR [^]
>>>
>>> Is [^] a correct regular expression?
>>>
>>> Thanks. Dmitry.
>>>
>>> Matt Wilmas wrote:
>>>> Hi Dmitry, Brian, all,
>>>>
>>>> Here's a scanner patch that I mentioned awhile ago, with a possible
>>>> way to work around the re2c EOF handling issues.
>>>>
>>>> The primary change is to do a "manual scan" like I talked about in
>>>> areas that match large amounts and can contain NULL bytes
>>>> (strings/comments, which are now scanned faster too), as is done for
>>>> inline HTML.  I called it a "diet" :-) because it removes my
>>>> complicated string regex patterns from a couple years ago, which
>>>> doesn't make the .l file much smaller after adding the manual scan
>>>> code (easier to understand...?), but it does result in a ~34k
>>>> reduction of 5.3's generated .c file...
>>>>
>>>> This fixes Bug #46817, as well as a better, more proper fix for the
>>>> older Bug #42767, both related to ending comments.
>>>>
>>>> Now inline HTML chunks aren't broken up when a tag starting with "s"
>>>> is encountered (<script> for JS, <span>, etc.), since it's unlikely to
>>>> be a long PHP <script> tag.
>>>>
>>>> If an opening PHP <SCRIPT> tag was used with a capital "S", it was
>>>> missed if it wasn't the first thing scanned:
>>>>
>>>> var_dump(token_get_all("HTML... <SCRIPT language=php>"));
>>>>
>>>> Single-line comments with a Windows newline didn't include the full \r\n:
>>>>
>>>> var_dump(token_get_all("<?php // Comment\r\n?>"));
>>>>
>>>> Finally, part of the optimized scanning is that, for double quoted
>>>> strings, when the first variable is encountered (making it
>>>> non-constant), the amount that's been scanned up to that point is
>>>> remembered, which can then be skipped over (up to the variable) after
>>>> returning the quote token. Previously that initial part of the string
>>>> was rescanned -- the cost dependent on how far "into" the string the
>>>> first var is.
>>>>
>>>>
>>>> I think that's about all --  I'll send another message if I forgot to
>>>> mention anything...  Just wanted to send this along quick for to you
>>>> guys to look at or whatever.  It was basically done last week, I just
>>>> had to do a couple finishing touches and verify that everything was OK.
>>>>
>>>> http://realplain.com/php/scanner_diet.diff (Merged changes, but didn't
>>>> test yet.)
>>>> http://realplain.com/php/scanner_diet_5_3.diff
>>>>
>>>>
>>>> Thanks,
>>>> Matt
>>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> 
> Aha - bottom of section at http://re2c.org/manual.html#lbAJ

-- 
Wbr, 
Antony Dovgal