Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43757 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18536 invoked from network); 22 Apr 2009 18:43:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Apr 2009 18:43:23 -0000 Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.116 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.116 us-gw1.zend.com Windows 2000 SP4, XP SP1 Received: from [63.205.162.116] ([63.205.162.116:62416] helo=us-gw1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 46/D3-33545-A456FE94 for ; Wed, 22 Apr 2009 14:43:22 -0400 Received: from [192.168.16.112] ([192.168.16.112]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 22 Apr 2009 11:43:09 -0700 Message-ID: <49EF6546.7010700@zend.com> Date: Wed, 22 Apr 2009 11:43:18 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Dmitry Stogov CC: =?ISO-8859-1?Q?Johannes_Schl=FCter?= , Matt Wilmas , internals@lists.php.net, Lukas Kahwe Smith References: <49D468CA.5050200@zend.com> <49D65752.6020207@zend.com> <1240353466.5797.32.camel@goldfinger> <49EEE690.4030004@zend.com> In-Reply-To: <49EEE690.4030004@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 22 Apr 2009 18:43:09.0874 (UTC) FILETIME=[2F003920:01C9C37A] Subject: Re: [PHP-DEV] Re: [PATCH] double to long conversion change From: stas@zend.com (Stanislav Malyshev) Hi! > Really, I don't understand what it's going to fix (the need of > preserving low bits looks strange for me). From what I understand the idea of the patch is what we are doing if we try to convert double that's too big for long into long (please correct me if I'm talking nonsense here). We'd then have to "cut" it, and as I understand there could be two approaches - either bitwise cut or just putting there some pre-determined value like LONG_MAX. I also understand the former was behavior in 5.2 and before (but not in 5.3 as of now), and thus I think it makes sense to keep this behavior, unless there is some serious problem with it - and I understand we don't know now about any such problem. Am I right? > Also it breaks ~30 tests. Now that should be checked out - are those directly related to the said conversion (i.e. the issue is that the tests just expect different behavior which is natural and we just have to fix the tests) or those are independent tests. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com