Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43756 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3586 invoked from network); 22 Apr 2009 09:42:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Apr 2009 09:42:49 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.185 il-mr1.zend.com Received: from [212.25.124.185] ([212.25.124.185:54313] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B5/AF-21597-696EEE94 for ; Wed, 22 Apr 2009 05:42:47 -0400 Received: from il-gw1.zend.com (unknown [10.1.1.21]) by il-mr1.zend.com (Postfix) with ESMTP id 1662D5034E; Wed, 22 Apr 2009 13:15:44 +0300 (IDT) Received: from ws.home ([10.1.10.5]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 22 Apr 2009 12:42:33 +0300 Message-ID: <49EEE690.4030004@zend.com> Date: Wed, 22 Apr 2009 13:42:40 +0400 User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= CC: Matt Wilmas , internals@lists.php.net, Stas Malyshev , Lukas Kahwe Smith References: <49D468CA.5050200@zend.com> <49D65752.6020207@zend.com> <1240353466.5797.32.camel@goldfinger> In-Reply-To: <1240353466.5797.32.camel@goldfinger> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-OriginalArrivalTime: 22 Apr 2009 09:42:33.0524 (UTC) FILETIME=[A96DFF40:01C9C32E] Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Re: [PATCH] double to long conversion change From: dmitry@zend.com (Dmitry Stogov) I looked into it some time ago. Really, I don't understand what it's going to fix (the need of=20 preserving low bits looks strange for me). Also it breaks ~30 tests. Thanks. Dmitry. Johannes Schl=FCter wrote: > On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote: >> Hi Dmitry, >> >> I finally updated the patches: >> http://realplain.com/php/dval_to_lval.diff >> http://realplain.com/php/dval_to_lval_5_3.diff >=20 > Has anybody (Dmitry?) reviewed this or other feedback? >=20 > johannes >=20 >=20