Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43755 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86061 invoked from network); 22 Apr 2009 06:56:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Apr 2009 06:56:47 -0000 Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.172 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 209.85.220.172 mail-fx0-f172.google.com Received: from [209.85.220.172] ([209.85.220.172:62846] helo=mail-fx0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A7/4C-21597-DAFBEE94 for ; Wed, 22 Apr 2009 02:56:47 -0400 Received: by fxm20 with SMTP id 20so2914742fxm.23 for ; Tue, 21 Apr 2009 23:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ESaRhjF+GgEM3fmwLVi+8Y5oCo8JOv8Sw1XCn+FXXrw=; b=j8xisew+vHPVRC8NC+KXAHUoLGDnc4gH0qz3kZpD18XKK1VTI/d/GK6kJoWbfX7G70 pPN6Syk+TMvdWIRJuOjUcuRqWKAinAkMrD/nIEDJZTvAHg1vyVgDZvlTiEcuyM3JMMji U85I7AMvkb9IV+mHyW131Il0Xw9kEK3k71Zk0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=XmO4eO6QQUHj728Jzb2qUhbpwPQ5v4Kn4seV5bJVBcVY3OLSEHJHf7VqmlBKF84WMA 3RZZZH3t6Ru1k8nl0IfPFWiGKhAn0n7OyUZ3OfijixEbogk4HmmnnbyhC4Y+SLxJapZV iuqxCjtfuxWvmhmZXjmi1fbwiSgVrRXuE2g8g= MIME-Version: 1.0 Received: by 10.204.58.130 with SMTP id g2mr7331008bkh.45.1240383402743; Tue, 21 Apr 2009 23:56:42 -0700 (PDT) In-Reply-To: <1240357055.6159.9.camel@goldfinger> References: <2dedb8a0902061106p4333682g56a1ec29196e7f3e@mail.gmail.com> <1240357055.6159.9.camel@goldfinger> Date: Wed, 22 Apr 2009 08:56:42 +0200 Message-ID: <7f3ed2c30904212356x17fc759dm64a4a793dd3360f@mail.gmail.com> To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: Kalle Sommer Nielsen , Internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Throwing E_DEPRECATED on startup From: hannes.magnusson@gmail.com (Hannes Magnusson) 2009/4/22 Johannes Schl=FCter : > On Fri, 2009-02-06 at 20:06 +0100, Kalle Sommer Nielsen wrote: >> I'd like to propose a change for when PHP starts to throw an >> E_DEPRECATED notice for each of the deprecated ini directives (such as >> register_globals, safe_mode ect.) like in HEAD where they just throw a >> warning (more about that below). I have attached a patch for this in >> 5.3 (which is the only branch this patch really relates to). > > Yeah. > > Good thing to notice the user of bad configuration. I'm wondering a bit > how we can educate people about magic_quotes_gpc ... people who blindly > disable them probably break stuff which is "secure" by accident. This is > not only relevant to this patch though. The best idea I have is a clear > pointer to the docs from the message ... There are couple of issues with throwing errors at startup: 1) They are thrown so damn early that the user will never see them 2) run-tests.php gets very confused and starts expecting HTTP headers in the EXPECT section If we could delay the checks until after php_module_startup().. -Hannes