Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43750
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.218.161 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=K4dAIeitfQ88NTom2/mLkhjBTELHsYS2AEFM/2hDgYn7RBiQdqm+8Ym1bQgOxJeHVv
         wCXX9TXAxvN2jEHydnf55r+q2fLtNCdrKv74Da0EzzHIyxthOXp3EBFVHipq0LbvdM2k
         QnKe3SUPSmnVLUMAQtgCu+dSmHdz5dHb8N5EQ=
Message-ID: <49EE1C9D.9030903@googlemail.com>
Date: Tue, 21 Apr 2009 20:21:01 +0100
User-Agent: Thunderbird 2.0.0.21 (X11/20090318)
MIME-Version: 1.0
To: Greg Beaver <greg@chiaraquartet.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
References: <49E731C3.4050201@chiaraquartet.net>
In-Reply-To: <49E731C3.4050201@chiaraquartet.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] detecting bad --CLEAN-- sections
From: zoe.slattery@googlemail.com (zoe)

Greg Beaver wrote:
> hi,
>
> I've noticed that it is very difficult to tell if your --CLEAN--
> sections are actually working, so I wonder if it might be possible to
> brainstorm ways of fixing this.
>   
Yes, I found the same thing and fixed 40 tests under ext/standard/tests 
last week - in PHP53. Tedious work.
> A couple of options come to mind that could be considered
>
> - append this code to the end of the .clean.php file: ?><?php echo
> "--CLEAN-- works"; ?> and capture the output, then check to make sure
> that we see "--CLEAN-- works" in the output.  This would detect fatal
> errors (which is the most common problem I find, especially when a
> --CLEAN-- section includes a helper file).
> - add a --REMOVEFILES--/--REMOVEDIRS-- section where one can specify
> relative paths to files or whole directories that should be nixed, and
> have run-tests do the removal
>   
In the new run-tests code (http://cvs.php.net/viewvc.cgi/phpruntests/) 
we just check and warn if there is *any* output from executing the CLEAN 
section. This works in the sense that it's how I found all the messed up 
tests.

If you want to talk about other requirements for that code I think 
php-qa is the right place to do it. By the way, - CLEAN-- sections 
aren't the aren't the only problems. I've found a few sections called 
--SKIP--, which of course do nothing :-).

I  started a requirements page for the new code, here 
wiki.php.net/qa/runtests, but I think it's better to discuss on the list 
before adding there.

Zoe