Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43718 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9908 invoked from network); 16 Apr 2009 13:25:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Apr 2009 13:25:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=greg@chiaraquartet.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=greg@chiaraquartet.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 209.85.221.121 cause and error) X-PHP-List-Original-Sender: greg@chiaraquartet.net X-Host-Fingerprint: 209.85.221.121 mail-qy0-f121.google.com Received: from [209.85.221.121] ([209.85.221.121:60049] helo=mail-qy0-f121.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A3/1B-48313-BC137E94 for ; Thu, 16 Apr 2009 09:25:32 -0400 Received: by qyk27 with SMTP id 27so649928qyk.29 for ; Thu, 16 Apr 2009 06:25:28 -0700 (PDT) Received: by 10.224.19.139 with SMTP id a11mr1739901qab.110.1239888325599; Thu, 16 Apr 2009 06:25:25 -0700 (PDT) Received: from ?192.168.1.19? ([173.9.108.154]) by mx.google.com with ESMTPS id 26sm1800755qwa.12.2009.04.16.06.25.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 16 Apr 2009 06:25:24 -0700 (PDT) Message-ID: <49E731C3.4050201@chiaraquartet.net> Date: Thu, 16 Apr 2009 08:25:23 -0500 User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807) MIME-Version: 1.0 To: PHP Developers Mailing List X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: detecting bad --CLEAN-- sections From: greg@chiaraquartet.net (Greg Beaver) hi, I've noticed that it is very difficult to tell if your --CLEAN-- sections are actually working, so I wonder if it might be possible to brainstorm ways of fixing this. A couple of options come to mind that could be considered - append this code to the end of the .clean.php file: ?> and capture the output, then check to make sure that we see "--CLEAN-- works" in the output. This would detect fatal errors (which is the most common problem I find, especially when a --CLEAN-- section includes a helper file). - add a --REMOVEFILES--/--REMOVEDIRS-- section where one can specify relative paths to files or whole directories that should be nixed, and have run-tests do the removal The most common usage for --CLEAN-- is to remove files, so I like the second option personally. Thanks, Greg