Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43708 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95989 invoked from network); 15 Apr 2009 02:15:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Apr 2009 02:15:24 -0000 Received: from [127.0.0.1] ([127.0.0.1:25950]) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ECSTREAM id 8C/1B-50915-C3345E94 for ; Tue, 14 Apr 2009 22:15:24 -0400 Authentication-Results: pb1.pair.com header.from=saramg@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=saramg@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.46.29 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: saramg@gmail.com X-Host-Fingerprint: 74.125.46.29 yw-out-2324.google.com Received: from [74.125.46.29] ([74.125.46.29:5362] helo=yw-out-2324.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/8A-50915-0B045E94 for ; Tue, 14 Apr 2009 22:04:33 -0400 Received: by yw-out-2324.google.com with SMTP id 3so1736831ywj.83 for ; Tue, 14 Apr 2009 19:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=tHpa8m2htinVpTTCjiC/qNgcF1DhOQwc9zRXuMaVVE0=; b=EKqWb08GrLPUJ2YeTOHREUyL7zITmlmx9tvHcrfTcF3rGf+jS/mxeIB9eC21pKY4gz 84swc74Hz14JfD+wXw+qhIi/meexQGFLkg6YOoNvRLa1KBtuMFNXbDWft0Dpd76fXdp4 bIZKt+J10hJA6+agHT3ci67uPrzSuttZcNATQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=iTC6UegKbhp1YGxgBgH0fMtCYWUeEl21UlbpHb/tRVWsn22xtot37/zntw3lpP0sSj eUbrtjEk0NDhQ3Lx5HL0g2Ed0bPunAfuD/xilCBm5PdwPzf/VYmisn5OFzibzRr1dfoL vMI+4qjzcC0dmAbeSEeUY9nmfkHBTgcBeXxbQ= MIME-Version: 1.0 Sender: saramg@gmail.com Received: by 10.231.19.72 with SMTP id z8mr2353597iba.6.1239761069609; Tue, 14 Apr 2009 19:04:29 -0700 (PDT) In-Reply-To: <49E4A4CD.5010809@zend.com> References: <49E4A4CD.5010809@zend.com> Date: Tue, 14 Apr 2009 19:04:29 -0700 X-Google-Sender-Auth: 234301a254176257 Message-ID: <3cf130880904141904h23d11d44p9bf988dee6a86027@mail.gmail.com> To: Dmitry Stogov Cc: PHP Internals , Lukas Kahwe Smith , =?UTF-8?Q?Johannes_Schl=C3=BCter?= , Stas Malyshev , Andi Gutmans Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: Support for "Transfer-Encoding: chunked" in http stream wrapper From: pollita@php.net (Sara Golemon) > The attached patch implements automatic decoding of chunked > transfer-encoding. > > Any objections against committing the patch into PHP_5_3? > I didn't have objections when I offered this filter several years ago, and I still don't. I do recall Andi (or perhaps it was someone else) saying it was adding unnecessary complexity to the http wrapper and such things should be left for cURL though, and this is why it didn't go into 5.1 > Maybe someone has ideas about patch improvements? > I'd add a context option to disable automatic application of the filter, and register the filter with the streams layer so that it can be applied manually. (And of course, I'd second Stas' comment wrt chunk-header length) The issue wrt 1.0 versus 1.1 is fairly moot. If the caller doesn't override the version then the server won't send chunked encoding. They are capable of doing so however, and they may already be doing it (e.g. for a streaming client). So the concern about potential BC breakage for apps still exists, it's just less severe (since I doubt many apps *are* explicitly setting the version to 1.1) -Sara