Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43654
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Cc: Justin Martin <frozenfire@thefrozenfire.com>,
 internals@lists.php.net
Message-ID: <8C61D88F-DB51-41E1-B217-B4B790E381A9@pooteeweet.org>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@php.net>
In-Reply-To: <1238693616.7327.7.camel@goldfinger>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Tue, 7 Apr 2009 16:42:23 +0200
References: <6F.F0.47115.84534D94@pb1.pair.com> <1238693616.7327.7.camel@goldfinger>
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 02.04.2009, at 19:33, Johannes Schl=FCter wrote:

> Hi,
>
> On Wed, 2009-04-01 at 20:47 -0700, Justin Martin wrote:
>> The update I'd like to propose is to the Zend Highlighter for PHP,
>> specifically related to the highlight_file and highlight_string
>> functions, as well as the php -s command.
>
> I don't see the need for a rush (or in other words: 5.3 can happily =20=

> live
> without it imo) and for the general consideration there's still my =20
> patch
> from 2005 using a <ol> to have line numbers and adding id's so lines =20=

> can
> directly be accessed by an URL.
>
> http://schlueters.de/~johannes/php/zend_highlight_20050312_1.diff
>
> About ini settings: We should avoid adding them as much as possible,
> making this an ini setting gives you trouble in case the admin plays
> with them for some reason and you don't overwrite them in the =20
> script, on
> the other hand it's the only way to make it work with "php -s" and the
> apache sapi's application/x-httpd-php-source.
>
> So in summary: Let's think carefully about this before committing the
> first idea which comes to mind.


+1 .. lets get this sorted out in HEAD. Both the styling and the =20
optional support for line numbers and anchors.

As for Chris Stockton's proposal for simply having an array parameter =20=

with predefined keys, is this the first time we are starting to feel =20
the need for named parameters in a real world example of something to =20=

be added to core? I know that several users have proposed such a =20
feature before, but imho before we start adding arrays as a poor mans =20=

named parameter support, we might want to open that pandoras box =20
again. Again nothing for 5.3 .. HEAD is where its at.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org