Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error)
Message-ID: <08D45CD5FF6A4A30BA67DC2D50CB5F52@pc1>
To: "php-dev List" <internals@lists.php.net>,
	<shire@php.net>
Cc: "Lukas Kahwe Smith" <mls@pooteeweet.org>,
	"Pierre Joye" <pierre.php@gmail.com>,
	"Dmitry Stogov" <dmitry@php.net>,
	"Christian Seiler" <chris_se@gmx.net>
References: <B3E41C55-0E3A-4EF6-B11A-E14AFE438204@pooteeweet.org> <fe05d1540903301527n312e8e5dy4f99f490283662e@mail.gmail.com> <90FF707C-391F-4FF4-8C5E-2AECEB48EB78@pooteeweet.org> <7C741E86-7720-4C87-8A43-BCC34520F0B5@pooteeweet.org> <0729A9B70D864C6E929169523CEBCB11@pc1> <49DA38C7.10006@php.net>
Date: Mon, 6 Apr 2009 13:22:35 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RC2 and integer/float handling in 5.3
From: php_lists@realplain.com ("Matt Wilmas")

Hi Brian,

----- Original Message -----
From: "shire"
Sent: Monday, April 06, 2009

> Matt Wilmas wrote:
>> Oh, other than that about the RC2 subject, I was also going to propose
>> some scanner changes like I mentioned to Brian on the 26th. Assuming it
>> works like in my head, it would basically be a big "diet" for the
>> scanner, making string/comment handling smaller and simpler, while
>> addressing the cause (for strings/comments at least) of Bug #46817
>> (tokenizer misses last single-line comment) which is wrongly marked
>> Closed and DONE on the wiki. Before RC1, Brian reverted his changes
>> that, I guess, had fixed it.
>
> It is?  I just tested this again to be sure something wasn't missed and it
> looks like it's working to me.  Which test case where you using?

Yep, 5.3's snapshot self-compiled from a couple days ago on Windows (not 
that that should matter).  (I'm not regenerating it with re2c, which also 
shouldn't matter; using the existing .c file.  I haven't touched the scanner 
stuff in a long time (yet) to regen.)  Scanner of course hasn't changed 
since then.

Test case is the one in the bug report. :-)  Last token is not the comment, 
but whitespace.  No problem on 5.2.9.  (From the scanner code, and current 
re2c behavior, I don't see why the behavior would be different than what I'm 
getting.)

Also, the unterminated comment Warning is still missing with "<?php /* blah 
" like it's been since the re2c change (except maybe for the time your fix 
was applied).  My changes would clean this up of course, unless you do 
something first.

> -shire

- Matt