Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43626 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34733 invoked from network); 4 Apr 2009 16:02:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Apr 2009 16:02:36 -0000 Authentication-Results: pb1.pair.com smtp.mail=r.borschel@gmx.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=r.borschel@gmx.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.net designates 213.165.64.20 as permitted sender) X-PHP-List-Original-Sender: r.borschel@gmx.net X-Host-Fingerprint: 213.165.64.20 mail.gmx.net Linux 2.6 Received: from [213.165.64.20] ([213.165.64.20:50850] helo=mail.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 12/13-01679-B9487D94 for ; Sat, 04 Apr 2009 11:02:36 -0500 Received: (qmail invoked by alias); 04 Apr 2009 16:02:31 -0000 Received: from e178172176.adsl.alicedsl.de (EHLO [192.168.0.43]) [85.178.172.176] by mail.gmx.net (mp045) with SMTP; 04 Apr 2009 18:02:31 +0200 X-Authenticated: #13379417 X-Provags-ID: V01U2FsdGVkX19+SzJvosp+XwLH1ih6VTYqgDu49GOQoZ4L2tTDl8 nisaWU0MFuoF0Q Cc: PHP Developers Mailing List Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= In-Reply-To: <1238844191.5741.8.camel@goldfinger> Content-Type: multipart/mixed; boundary=Apple-Mail-2-708226411 Mime-Version: 1.0 (Apple Message framework v930.3) Date: Sat, 4 Apr 2009 18:02:27 +0200 References: <2FA0A495-EC1A-4C51-9EE6-F9680D9FD114@gmx.net> <1238802796.5741.1.camel@goldfinger> <11478D41-777A-42BC-9CE7-105FFFEA4B74@gmx.net> <594A574F-E6B2-4FDD-92D3-4492D0DD2A5D@gmx.net> <1238844191.5741.8.camel@goldfinger> X-Mailer: Apple Mail (2.930.3) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.83,0.59 Subject: Re: [PHP-DEV] Private properties, Inheritance, Reflection (5.3) From: r.borschel@gmx.net (Roman Borschel) --Apple-Mail-2-708226411 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Hi, i created 2 patches that are attached to this mail, one to fix the issue and the other to add tests for it (I added them into reflectionProperty_setAccessible.phpt). Roman --Apple-Mail-2-708226411 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-2-708226411 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On Apr 4, 2009, at 1:23 PM, Johannes Schl=FCter wrote: > On Sat, 2009-04-04 at 13:08 +0200, Roman Borschel wrote: >> My "patch" is simply to replace the first argument of >> zend_update_property/zend_read_property in ext/php_reflection.c like >> this: > [...] >> So simply replacing Z_OBJCE_P(object) with ref->ce. > > yes, that was what i was thinking about, too after my first look, =20 > but I > have no test environment on this box, will try it later, if nobody =20 > steps > in tests&commits :-) > > johannes > > > --=20 > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php --Apple-Mail-2-708226411--