Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43605 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56383 invoked from network); 2 Apr 2009 17:33:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Apr 2009 17:33:47 -0000 Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.134 mailout2.netbeat.de Linux 2.6 Received: from [83.243.58.134] ([83.243.58.134:42677] helo=mailout2.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CB/21-44124-8F6F4D94 for ; Thu, 02 Apr 2009 12:33:46 -0500 Received: (qmail 20395 invoked by uid 89); 2 Apr 2009 17:58:48 -0000 Received: from unknown (HELO ?192.168.1.101?) (johannes%schlueters.de@93.104.127.212) by mailout2.netbeat.de with ESMTPA; 2 Apr 2009 17:58:48 -0000 To: Justin Martin Cc: internals@lists.php.net In-Reply-To: <6F.F0.47115.84534D94@pb1.pair.com> References: <6F.F0.47115.84534D94@pb1.pair.com> Content-Type: text/plain Date: Thu, 02 Apr 2009 19:33:36 +0200 Message-ID: <1238693616.7327.7.camel@goldfinger> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Update to Zend Highlighter From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Wed, 2009-04-01 at 20:47 -0700, Justin Martin wrote: > The update I'd like to propose is to the Zend Highlighter for PHP, > specifically related to the highlight_file and highlight_string > functions, as well as the php -s command. I don't see the need for a rush (or in other words: 5.3 can happily live without it imo) and for the general consideration there's still my patch from 2005 using a
    to have line numbers and adding id's so lines can directly be accessed by an URL. http://schlueters.de/~johannes/php/zend_highlight_20050312_1.diff About ini settings: We should avoid adding them as much as possible, making this an ini setting gives you trouble in case the admin plays with them for some reason and you don't overwrite them in the script, on the other hand it's the only way to make it work with "php -s" and the apache sapi's application/x-httpd-php-source. So in summary: Let's think carefully about this before committing the first idea which comes to mind. johannes