Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43598
Return-Path: <robert@interjinn.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 20800 invoked from network); 2 Apr 2009 15:02:19 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Apr 2009 15:02:19 -0000
Authentication-Results: pb1.pair.com header.from=robert@interjinn.com; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=robert@interjinn.com; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain interjinn.com from 66.11.173.122 cause and error)
X-PHP-List-Original-Sender: robert@interjinn.com
X-Host-Fingerprint: 66.11.173.122 unknown  
Received: from [66.11.173.122] ([66.11.173.122:56353] helo=interjinn.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id FB/E1-22853-A73D4D94 for <internals@lists.php.net>; Thu, 02 Apr 2009 10:02:19 -0500
Received: from [192.168.1.3] (blobule.suds [192.168.1.3])
	by interjinn.com (Postfix) with ESMTP id 8EA4411FB6F;
	Thu,  2 Apr 2009 11:01:55 -0400 (EDT)
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Scott MacVicar <scottmac@php.net>,
	David Coallier <davidc@php.net>,
	Justin Martin <frozenfire@thefrozenfire.com>, internals@lists.php.net
In-Reply-To: <2dedb8a0904020745gf2d9e19wd0f1167dae53ac2d@mail.gmail.com>
References: <6F.F0.47115.84534D94@pb1.pair.com>
	 <2dedb8a0904020508r6306c189peda001421d4e830f@mail.gmail.com>
	 <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com>
	 <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
	 <49D4CE5F.3070805@php.net>
	 <2dedb8a0904020745gf2d9e19wd0f1167dae53ac2d@mail.gmail.com>
Content-Type: text/plain
Organization: InterJinn
Date: Thu, 02 Apr 2009 11:02:23 -0400
Message-ID: <1238684543.8765.141.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: robert@interjinn.com (Robert Cummings)

On Thu, 2009-04-02 at 16:45 +0200, Kalle Sommer Nielsen wrote:
> Hi Scott
> 
> 2009/4/2 Scott MacVicar <scottmac@php.net>:
> > David Coallier wrote:
> >> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
> >>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
> >>>> Hi Justin
> >>>>
> >>> Attached a patch instead, hopefully this will work ;)
> >>>
> >>>
> >>
> >>
> >> I really do like this idea :) Let's just commit it.
> >
> > Hold your horses, lets not commit things hastily. I'm not a huge fan of
> > adding 6 new INI settings and I think have another idea so we can avoid
> > this and still offer more flexibility.
> 
> Sure 6 new INI settings sounds alot, but thinking about it theres
> already 6 to control the current (bg, default, comment, html, keyword
> & string) and 5 of these new ones is to control classes if theres a
> class naming conflict then a user can customize. So only one setting
> is needed to enable this feature.
> 
> But if you have a better way around this then I'm all ears :)

Wrap the whole  highlighted block in a div with a class:

    <div class="php-highlighted-code">
    </div>

Add one more INI setting to change that class. Let users leverage
hierarchical CSS rules:

div.php-highlighted-code span.keyword { color: red; }

Cheers,
Rob.
-- 
http://www.interjinn.com
Application and Templating Framework for PHP