Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43597
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.172 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=ShYqOaOe945rEr7nshL93Yg/VzCrucWhVojg+iov/1blH2lQlPBlZvsTCOjcuJ2L2e
         rUThk87qkHx1N3C3B/ta72rHu6ej52Eu10tUZleW6IzXgz4NJUlYl4SPq2y1683rxhhB
         MrCqsu5gwYSo3aywDkUVtsXjGYUncaCB8cKJw=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <49D4CE5F.3070805@php.net>
References: <6F.F0.47115.84534D94@pb1.pair.com>
	 <2dedb8a0904020508r6306c189peda001421d4e830f@mail.gmail.com>
	 <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com>
	 <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
	 <49D4CE5F.3070805@php.net>
Date: Thu, 2 Apr 2009 16:45:56 +0200
Message-ID: <2dedb8a0904020745gf2d9e19wd0f1167dae53ac2d@mail.gmail.com>
To: Scott MacVicar <scottmac@php.net>
Cc: David Coallier <davidc@php.net>, Justin Martin <frozenfire@thefrozenfire.com>, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Scott

2009/4/2 Scott MacVicar <scottmac@php.net>:
> David Coallier wrote:
>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>>>> Hi Justin
>>>>
>>> Attached a patch instead, hopefully this will work ;)
>>>
>>>
>>
>>
>> I really do like this idea :) Let's just commit it.
>
> Hold your horses, lets not commit things hastily. I'm not a huge fan of
> adding 6 new INI settings and I think have another idea so we can avoid
> this and still offer more flexibility.

Sure 6 new INI settings sounds alot, but thinking about it theres
already 6 to control the current (bg, default, comment, html, keyword
& string) and 5 of these new ones is to control classes if theres a
class naming conflict then a user can customize. So only one setting
is needed to enable this feature.

But if you have a better way around this then I'm all ears :)

>
>>
>> I would however like ot see the "naming" stucture Justin used in the
>> first example by prefixing the CSS classnames by "php". This will
>> greatly help the inclusion into other considering that "comment" and
>> "default" are widely used (not sure about the other ones) for general
>> purposes usage (see google codesearch for example).
>>
>> Cool work, do we go by adding 6 new ini settings and making sure they
>> are prefixed by default?
>>
>> Also I guess we'll have to attach a css file with that? Inline css at
>> the top of the generated highlighted block maybe?
>>
>
> No, the user would be responsible for producing the CSS sheet that they
> want.
>
> Scott
>



-- 
Kalle Sommer Nielsen
kalle@php.net