Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43596
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.159 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=wyz2/681Q3RkS8ZVMwrLT1ARNGVij3m9w3cCuvKNZpwQ/sEFdaIJ/wFj/nXDImZY5z
         8kqxZvBlsl4OASjpcQrToNJvj+fYNSORoPZxQF6DlYy8KnCYNr12e6sS1cpY/gvW0Qcj
         kqPmStgwah+MrdBfGTk3LPJwXi5YYnspCNBvQ=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
References: <6F.F0.47115.84534D94@pb1.pair.com>
	 <2dedb8a0904020508r6306c189peda001421d4e830f@mail.gmail.com>
	 <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com>
	 <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
Date: Thu, 2 Apr 2009 16:43:36 +0200
Message-ID: <2dedb8a0904020743s271d6603j1b86d011e0a33c0e@mail.gmail.com>
To: David Coallier <davidc@php.net>
Cc: Justin Martin <frozenfire@thefrozenfire.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: kalle@php.net (Kalle Sommer Nielsen)

Hi David

2009/4/2 David Coallier <davidc@php.net>:
> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>>> Hi Justin
>>>
>>
>> Attached a patch instead, hopefully this will work ;)
>>
>>
>
>
> I really do like this idea :) Let's just commit it.
>
> I would however like ot see the "naming" stucture Justin used in the
> first example by prefixing the CSS classnames by "php". This will
> greatly help the inclusion into other considering that "comment" and
> "default" are widely used (not sure about the other ones) for general
> purposes usage (see google codesearch for example).

We can just change the default values in zend_highlight.h to be
prefixed php-xxx aswell as in the ini.

>
> Cool work, do we go by adding 6 new ini settings and making sure they
> are prefixed by default?
>
> Also I guess we'll have to attach a css file with that? Inline css at
> the top of the generated highlighted block maybe?

If a user wants to use css classes for highlight, then he will have
his own styling. I don't think we should attempt to "fix" it on php
level if this feature is enabled by adding a <style> section.

>
> --
> Slan,
> David
>



-- 
Kalle Sommer Nielsen
kalle@php.net