Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43595
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 95.172.239.1 as permitted sender)
Message-ID: <49D4CE5F.3070805@php.net>
Date: Thu, 02 Apr 2009 15:40:31 +0100
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: David Coallier <davidc@php.net>
CC: Kalle Sommer Nielsen <kalle@php.net>, 
 Justin Martin <frozenfire@thefrozenfire.com>,
 internals@lists.php.net
References: <6F.F0.47115.84534D94@pb1.pair.com>	 <2dedb8a0904020508r6306c189peda001421d4e830f@mail.gmail.com>	 <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com> <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
In-Reply-To: <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has
	identified this incoming email as possible spam.  The original message
	has been attached to this so you can view it (if it isn't spam) or label
	similar future email.  If you have any questions, see
	the administrator of that system for details.
	Content preview:  David Coallier wrote: > 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
	>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>: >>> Hi Justin >>> >> Attached
	a patch instead, hopefully this will work ;) >> >> > > > I really do like
	this idea :) Let's just commit it. [...] 
	Content analysis details:   (-4.3 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	0.1 AWL                    AWL: From: address is in the auto white-list
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: scottmac@php.net (Scott MacVicar)

David Coallier wrote:
> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>>> Hi Justin
>>>
>> Attached a patch instead, hopefully this will work ;)
>>
>>
> 
> 
> I really do like this idea :) Let's just commit it.

Hold your horses, lets not commit things hastily. I'm not a huge fan of
adding 6 new INI settings and I think have another idea so we can avoid
this and still offer more flexibility.

> 
> I would however like ot see the "naming" stucture Justin used in the
> first example by prefixing the CSS classnames by "php". This will
> greatly help the inclusion into other considering that "comment" and
> "default" are widely used (not sure about the other ones) for general
> purposes usage (see google codesearch for example).
> 
> Cool work, do we go by adding 6 new ini settings and making sure they
> are prefixed by default?
> 
> Also I guess we'll have to attach a css file with that? Inline css at
> the top of the generated highlighted block maybe?
> 

No, the user would be responsible for producing the CSS sheet that they
want.

Scott