Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43593
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.167 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=dj13v6PvjILZ6JtCYPxyGqjqScs5DF9LFntedTxTxKJz6wGRLa+ZFVqeOWr5KbZToX
         /sp4JKzZAbvJjo1o4pRYDiOdOZqLPTAbkoMa5F/FG7YjLrlVdqBQjGr8xAUhvJtf9Tcf
         uBYPqDFKo9rtWSOB678FhPZ+d72h8tcsZkz2Y=
MIME-Version: 1.0
Sender: david.coallier@gmail.com
In-Reply-To: <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com>
References: <6F.F0.47115.84534D94@pb1.pair.com>
	 <2dedb8a0904020508r6306c189peda001421d4e830f@mail.gmail.com>
	 <2dedb8a0904020515k6bd68cdarea0ebd9bb3a8f6c9@mail.gmail.com>
Date: Thu, 2 Apr 2009 15:36:01 +0100
Message-ID: <b5f7bf6c0904020736w27476652i7d1fc36111389d13@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Justin Martin <frozenfire@thefrozenfire.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Update to Zend Highlighter
From: davidc@php.net (David Coallier)

2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
> 2009/4/2 Kalle Sommer Nielsen <kalle@php.net>:
>> Hi Justin
>>
>
> Attached a patch instead, hopefully this will work ;)
>
>


I really do like this idea :) Let's just commit it.

I would however like ot see the "naming" stucture Justin used in the
first example by prefixing the CSS classnames by "php". This will
greatly help the inclusion into other considering that "comment" and
"default" are widely used (not sure about the other ones) for general
purposes usage (see google codesearch for example).

Cool work, do we go by adding 6 new ini settings and making sure they
are prefixed by default?

Also I guess we'll have to attach a css file with that? Inline css at
the top of the generated highlighted block maybe?

-- 
Slan,
David