Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43527
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.179 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=TNfCPFzN3+PyFtYplhKYKb5exvsz2Yu0GYcmPmS4BiASXFFZP9QztrEakrLc3YvflH
         Le4gPT/hhI+sVoIrC3yapUzq5VzfX/hrVZO36RqDFcR8hzBzVG5e8RApXFM1DG5AKdXk
         tPwGGBgJB8tpOiNB7q6nmAcv9FM2hecR33Tso=
MIME-Version: 1.0
In-Reply-To: <2dedb8a0903271522g3614c215k696b4b31ead9d625@mail.gmail.com>
References: <744ffb620903271040t6f260e6bp893b6219f095e9fa@mail.gmail.com>
	 <744ffb620903271121g51290b9amdc26116280aec055@mail.gmail.com>
	 <49CD2334.4070207@sektioneins.de>
	 <744ffb620903271214w7a62f2d8wac87922702503fd2@mail.gmail.com>
	 <2dedb8a0903271522g3614c215k696b4b31ead9d625@mail.gmail.com>
Date: Fri, 27 Mar 2009 23:36:00 +0100
Message-ID: <744ffb620903271536s4a5fdc99lec47f2dc2261d1d1@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Stefan Esser <stefan.esser@sektioneins.de>, m.bretz@metropolis-ag.de, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch 
	input field
From: retricek@gmail.com (=?ISO-8859-2?Q?Josef_=A9im=E1nek?=)

OK, nice idea about that search in comments bug. I try to code it tonight.
Next, I found some illogical code in bug tracker source code. For
example, there is a file (include/config.php) with mysql access but it
is not using, but there are some pages using mysql_connect function
followed by mysql_select_db without constants defined in that file. I
think there is no reason for this, is there ?

2009/3/27 Kalle Sommer Nielsen <kalle@php.net>:
> Hi Josef
>
> 2009/3/27 Josef =A9im=E1nek <retricek@gmail.com>:
>> ok, but Mike Bretz wrote that it will be better to mark this bug as
>> "Bogus" according to all browsers auto-form completion function.
>> This patch was written very fast, without thinking. Next time I spend
>> more time to focus on security.
>>
>> ok, what about these bugs :
>> http://bugs.php.net/bug.php?id=3D46663
>> http://bugs.php.net/bug.php?id=3D40696
>>
>> Will be any improvement to focus on these bugs ?
>> Thank you for fast response.
>
> If you can come up with a good enough patch and idea to resolve the
> issue I don't see any reason for why they wouldn't be accepted. Both
> of them seems pretty straight forward, for example for #46663, a
> checkbox that can be checked to "search comments only" could be added
> and then modify the results page to snow a snippet of the comment that
> matches.
>
>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
>
> --
> Kalle Sommer Nielsen
> kalle@php.net
>