Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43508
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.159 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=xT0WPCUglgd/GgRahNtKXVv79z958itjB5LfpAAW8n8GuufvGSNYzLSFNBi2QcSWm+
         oYerKB1Dr4Vx2LnvL0WNfIYwTw3rwnsId/ZzaBG6FqVAmf2z5gcrceM41v+gFAr1X6ve
         xdfjNYlY7w0ThuJXynFq7gNidlsInRal2BsEg=
Sender: Arnaud LB <arnaud.lb@gmail.com>
To: Lukas Kahwe Smith <mls@pooteeweet.org>
Cc: php-dev <internals@lists.php.net>, Johannes =?ISO-8859-1?Q?Schl=FCter?= <johannes@php.net>, Kalle Sommer Nielsen <kalle@php.net>
In-Reply-To: <A3D57655-4D1D-4165-937F-9A5908F0A6D0@pooteeweet.org>
References: <1237469542.7120.81.camel@localhost>
	 <9C552133-ACEE-4615-B8A3-5B16BE8660CC@pooteeweet.org>
	 <1238027452.4733.92.camel@localhost>
	 <A3D57655-4D1D-4165-937F-9A5908F0A6D0@pooteeweet.org>
Content-Type: text/plain
Date: Fri, 27 Mar 2009 03:42:58 +0100
Message-ID: <1238121778.29616.4.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] un-deprecating ticks ?
From: lbarnaud@php.net (Arnaud Le Blanc)

On Thu, 2009-03-26 at 08:51 +0100, Lukas Kahwe Smith wrote:
> On 26.03.2009, at 01:30, Arnaud Le Blanc wrote:
> 
> > On Wed, 2009-03-25 at 20:05 +0100, Lukas Kahwe Smith wrote:
> >> On 19.03.2009, at 14:32, Arnaud Le Blanc wrote:
> >>
> >>> Hi,
> >>>
> >>> After having seen some complaints about ticks being deprecated I'm
> >>> wondering if they could be un-deprecated for now.
> >>>
> >>> Ticks are used by the pcntl extension to call signal handlers when
> >>> signals are triggered. I added some functions as an alternative, but
> >>> this does not covers all use cases (and forces a code change).
> >>>
> >>> When searching bug reports about ticks, one can feel the ticks to be
> >>> broken (and this is why they have been deprecated). However, looking
> >>> in
> >>> depth at these bugs and viewing what caused them and how they have
> >>> been
> >>> fixed does not show really bad things about ticks.
> >>>
> >>> Actually one thing is broken (and is marked as such in the
> >>> documentation), tick functions do not work in ZTS, this looks  
> >>> fixable.
> >>>
> >>> Any thoughts on removing the deprecation warning for now ? (at least
> >>> until a replacement is found).
> >>>
> >>> Sorry for posting this so close to the freeze.
> >>
> >>
> >> So what is it going to be?
> >> I remember everybody was happy when it was deprecated.
> >
> > The only thread I found about that is here:
> > http://marc.info/?l=php-internals&m=121442930703916&w=2
> >
> >> Indeed the only open ticket is #47198, which is the doc bug. Or did  
> >> we
> >> close tons of ticks bugs because it was deprecated?
> >
> > I've seen one bug marked as wont fix for this reason. I've searched  
> > for
> > "ticks" and looked at the last few pages of bugs, many was really  
> > bogus,
> > or documentation issues. Some was related to register_tick_function()
> > and are fixed. I seen nothing really bad or related to the engine.
> >
> > The ZTS issue looks fixable, this is a crash when using
> > register_tick_function() due to the list of functions not being  
> > initialized
> > in the threads.
> 
> 
> It seems to me like at this point its your call. You are the one that  
> has dug into this. If you feel you can fix things then I guess its  
> your call to undeprecate ticks. As for the bogus bugs, this maybe  
> indicate that we need to do some more work on the documentation. Could  
> you look into this as well? Overall we should do our dearest to  
> prevent that even stupid users can crash PHP and if something can too  
> easily be made to still crash PHP, maybe its something we shouldnt have.
> 

Ok, so I reverted the deprecation warning and fixed the ZTS issue.
I will take a look at the documentation.

Regards,

Arnaud