Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43437
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender)
Message-ID: <49C79ACF.50306@zend.com>
Date: Mon, 23 Mar 2009 17:21:03 +0300
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Lukas Kahwe Smith <mls@pooteeweet.org>
CC: Rasmus Lerdorf <rasmus@lerdorf.com>, 
 Matt Wilmas <php_lists@realplain.com>,
 internals@lists.php.net, =?ISO-8859-1?Q?Johannes_Schl=FCter?=
 <johannes@php.net>
References: <1113CE12226949C2939A31971420991F@pc1> <49C0A7C7.8000804@zend.com> <12E613FAA1C9422B948F00B61AD32366@pc1> <49C134E5.7020706@zend.com> <49C29EEF.9010702@lerdorf.com> <6418ED1D-5CC3-4CA9-8C06-80FBE9864190@pooteeweet.org>
In-Reply-To: <6418ED1D-5CC3-4CA9-8C06-80FBE9864190@pooteeweet.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: array kindex overflow issue Re: [PHP-DEV] Re: [PATCH] Bug #45877:
 LONG_MAX/MIN array key as string/int
From: dmitry@zend.com (Dmitry Stogov)



Lukas Kahwe Smith wrote:
> 
> On 19.03.2009, at 20:37, Rasmus Lerdorf wrote:
> 
>> So, what is the final conclusion on this one?  Are we at a combination
>> of Matt's and Dmitry's patches here?
>>
>> I think we definitely need to fix this even in the 5.2 branch and get it
>> back to 5.1.x and earlier behavior.  I consider it a bug that:
>>
>> $arr[3500000000] = 'blah';
>> print_r($arr);
>>
>> results in:
>>
>> [-2147483648] => blah
>>
>> if someone has written brand new 5.2-specific code that relies on this
>> weird behavior, then we will just have to bite the bullet and break that
>> code.  It is way more likely that people are relying on the earlier
>> behavior and will end up with subtle problems in 5.2.  I just had
>> someone at Yahoo get bitten by this when they upgraded from 5.1.x to 
>> 5.2.x.
> 
> 
> If I understood it properly, the issue Matt/Dmitry are working on is 
> something else. So where do we stand on the issue Rasmus's notes (is 
> there a ticket for this one already)?

It's related to another Matt's proposal which cares about float to long 
conversion.

Matt, what will we get with your patch and code above?
[LONG_MAX] => blah?

Thanks. Dmitry.

> regards,
> Lukas Kahwe Smith
> mls@pooteeweet.org
> 
> 
>