Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43404 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8899 invoked from network); 19 Mar 2009 06:15:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Mar 2009 06:15:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.163 il-gw1.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.163] ([212.25.124.163:62985] helo=il-gw1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 78/77-56035-5F2E1C94 for ; Thu, 19 Mar 2009 01:15:18 -0500 Received: from ws.home ([10.1.10.7]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 19 Mar 2009 08:16:42 +0200 Message-ID: <49C1E2ED.8080907@zend.com> Date: Thu, 19 Mar 2009 09:15:09 +0300 User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Matt Wilmas CC: internals@lists.php.net, Lukas Kahwe Smith , =?ISO-8859-1?Q?Johannes_Schl=FCter?= References: <1113CE12226949C2939A31971420991F@pc1> <49C0A7C7.8000804@zend.com> <12E613FAA1C9422B948F00B61AD32366@pc1> <49C134E5.7020706@zend.com> <570D833B543A4EB599F982488CDC41E4@pc1> In-Reply-To: <570D833B543A4EB599F982488CDC41E4@pc1> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Mar 2009 06:16:43.0117 (UTC) FILETIME=[45F7F1D0:01C9A85A] Subject: Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int From: dmitry@zend.com (Dmitry Stogov) Hi Matt, Matt Wilmas wrote: > Hi again Dmitry, > > Just wanted to say that I think I can make your code a bit smaller after > looking at it closer. It would be great, but keep in mind that performance is more important. > Don't quite have enough time to modify and verify > it now, but I'll be back later (around the usual time) to let you know > either way. :-) I'm waiting for your changes. Thanks. Dmitry. > > - Matt > > > ----- Original Message ----- > From: "Dmitry Stogov" > Sent: Wednesday, March 18, 2009 > >> Hi Matt, >> >> I suppose I fixed the patch. >> >> Could you please check which patch is better yours or the attached one? >> >> According to attached benchmark my one is faster for most usual cases, >> but may be I forget something again. >> >> $a["abcdefghij"] 0.130 0.130 >> $a["1234567890"] 0.187 0.104 >> $a["2147483648"] 0.168 0.142 >> $a["0"] 0.116 0.082 >> $a["214748364x"] 0.136 0.141 >> $a[0] 0.080 0.080 >> >> Also, do you have other patches which I could look into before RC? >> >> Thanks. Dmitry. >