Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43397
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error)
Message-ID: <570D833B543A4EB599F982488CDC41E4@pc1>
To: <internals@lists.php.net>,
	"Dmitry Stogov" <dmitry@zend.com>
Cc: "Lukas Kahwe Smith" <mls@pooteeweet.org>,
	=?iso-8859-1?Q?Johannes_Schl=FCter?= <johannes@php.net>
References: <1113CE12226949C2939A31971420991F@pc1> <49C0A7C7.8000804@zend.com> <12E613FAA1C9422B948F00B61AD32366@pc1> <49C134E5.7020706@zend.com>
Date: Wed, 18 Mar 2009 21:15:52 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int
From: php_lists@realplain.com ("Matt Wilmas")

Hi again Dmitry,

Just wanted to say that I think I can make your code a bit smaller after 
looking at it closer.  Don't quite have enough time to modify and verify it 
now, but I'll be back later (around the usual time) to let you know either 
way. :-)


- Matt


----- Original Message -----
From: "Dmitry Stogov"
Sent: Wednesday, March 18, 2009

> Hi Matt,
>
> I suppose I fixed the patch.
>
> Could you please check which patch is better yours or the attached one?
>
> According to attached benchmark my one is faster for most usual cases,
> but may be I forget something again.
>
> $a["abcdefghij"]   0.130 0.130
> $a["1234567890"]   0.187 0.104
> $a["2147483648"]   0.168 0.142
> $a["0"]            0.116 0.082
> $a["214748364x"]   0.136 0.141
> $a[0]              0.080 0.080
>
> Also, do you have other patches which I could look into before RC?
>
> Thanks. Dmitry.