Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43362 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20972 invoked from network); 16 Mar 2009 10:13:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Mar 2009 10:13:06 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.163 il-gw1.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.163] ([212.25.124.163:20236] helo=il-gw1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8F/10-19569-0362EB94 for ; Mon, 16 Mar 2009 05:13:05 -0500 Received: from ws.home ([10.1.10.19]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 16 Mar 2009 12:14:31 +0200 Message-ID: <49BE262B.4000106@zend.com> Date: Mon, 16 Mar 2009 13:12:59 +0300 User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Matt Wilmas CC: internals@lists.php.net References: <3B33483EE2074F84B5969CC101A6ACCA@pc1> In-Reply-To: <3B33483EE2074F84B5969CC101A6ACCA@pc1> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Mar 2009 10:14:31.0730 (UTC) FILETIME=[FF7C4120:01C9A61F] Subject: Re: [PATCH] Remove nTableSize from HashTable? From: dmitry@zend.com (Dmitry Stogov) Hi Matt, I don't see a lot of reason in this patch as the benefit is near invisible and readability becomes worse. Also the patch can break third-party modules like APC and Zend extensions. Even it's not a big problem as they can be easily fixed, I'm against of changing of core components without real benefit. Thanks. Dmitry. Matt Wilmas wrote: > Hi Dmitry, all, > > Just a quick one... ;^) Is there much, if any, advantage to removing > the HashTable member nTableSize? It's just nTableMask + 1, so it can be > derived easily in the couple places that need it... Figured it can't > hurt to make things smaller, and it only adds a couple addition > operations for resizing, basically. :-) > > Patches if you want the change (or tell me to commit): > http://realplain.com/php/tablesize.diff > http://realplain.com/php/tablesize_5_3.diff > > > - Matt