Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43355
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 38180 invoked from network); 15 Mar 2009 23:29:54 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 15 Mar 2009 23:29:54 -0000
Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6
Received: from [85.214.94.56] ([85.214.94.56:37426] helo=h1149922.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id C7/8B-06903-07F8DB94 for <internals@lists.php.net>; Sun, 15 Mar 2009 18:29:53 -0500
Received: from MBOERGER-ZRH.ad.corp.google.com (221-114.62-81.cust.bluewin.ch [81.62.114.221])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by h1149922.serverkompetenz.net (Postfix) with ESMTP id 989EB11F36A;
	Mon, 16 Mar 2009 00:29:49 +0100 (CET)
Date: Mon, 16 Mar 2009 00:28:24 +0100
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <398413748.20090316002824@marcus-boerger.de>
To: "Matt Wilmas" <php_lists@realplain.com>
CC: internals@lists.php.net, "Dmitry Stogov" <dmitry@zend.com>
In-Reply-To: <3B33483EE2074F84B5969CC101A6ACCA@pc1>
References: <3B33483EE2074F84B5969CC101A6ACCA@pc1>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Remove nTableSize from HashTable?
From: helly@php.net (Marcus Boerger)

Hello Matt,

  if there is no advantage in doing so, why offer a patch?

Ok, you probably meant disadvantage. And the advantge of doing so is
probably a lower memory foot print. Did you by any chance run any
profiling? Without numbers, I guess it is not worth the effort changing
a core component.

Sunday, March 15, 2009, 5:22:06 PM, you wrote:

> Hi Dmitry, all,

> Just a quick one... ;^)  Is there much, if any, advantage to removing the 
> HashTable member nTableSize?  It's just nTableMask + 1, so it can be derived
> easily in the couple places that need it...  Figured it can't hurt to make 
> things smaller, and it only adds a couple addition operations for resizing,
> basically. :-)

> Patches if you want the change (or tell me to commit):
> http://realplain.com/php/tablesize.diff
> http://realplain.com/php/tablesize_5_3.diff


> - Matt 





Best regards,
 Marcus