Newsgroups: php.apc.dev,php.internals Path: news.php.net Xref: news.php.net php.apc.dev:201 php.internals:43296 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56746 invoked from network); 10 Mar 2009 18:20:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Mar 2009 18:20:46 -0000 Authentication-Results: pb1.pair.com smtp.mail=shire@tekrat.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=shire@tekrat.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain tekrat.com from 208.43.138.18 cause and error) X-PHP-List-Original-Sender: shire@tekrat.com X-Host-Fingerprint: 208.43.138.18 sizzo.org Linux 2.6 Received: from [208.43.138.18] ([208.43.138.18:35763] helo=sizzo.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9E/AE-15363-C7FA6B94 for ; Tue, 10 Mar 2009 13:20:45 -0500 Received: from 70-0-113-110.pools.spcsdns.net (70-0-113-110.pools.spcsdns.net [70.0.113.110]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by sizzo.org (Postfix) with ESMTPSA id DF5FDCBE58F; Tue, 10 Mar 2009 11:20:40 -0700 (PDT) Message-ID: <49B6AF73.2050506@tekrat.com> Date: Tue, 10 Mar 2009 11:20:35 -0700 User-Agent: Postbox 1.0b8 (Macintosh/2009030315) MIME-Version: 1.0 To: Lukas Kahwe Smith CC: PHP Internals List , apc-dev@lists.php.net References: <49A097FE.10205@tekrat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] APC/PHP Lazy Loading From: shire@tekrat.com (shire) Lukas Kahwe Smith wrote: > > On 22.02.2009, at 01:10, shire wrote: > >> >> I've just checked into APC CVS preliminary support for Lazy Loading >> classes and functions. This means that rather than copying function >> entries into EG(function_table) and EG(class_table) when an include >> happen it will mark the functions/classes as available and only >> actually insert them into the tables when they are called. This is >> done via hooks added into the various hash table lookups in PHP. I've >> placed a patch for PHP_5_3 at: >> >> http://tekrat.com/downloads/bits/apc_lazy_php53.patch > > > I did not read through the entire thread. As things are close to RC > state in 5.3, I would prefer to not do any non bug fixes at this stage. > Then again if the benefits are huge and the risk is low it can be > considered of course .. Yep, I should have been clearer here. ;-) I don't believe this patch is ready to be committed and I'm not advocating for inclusion in the php53 release. I have some more adjustments I'd like to make to both the APC code and this patch, both for optimization, cleanliness, and to ensure it's the best possible implementation for future enhancements (such as lazy loading methods). I'm more interested in getting constructive feedback and any benchmark results so I can make adjustments to the current code. However, I would like to come back with improved patches and get it included in the next major release as appropriate. I'm all about fixing the remaining php53 todos/bugs and getting this release out! I hope posting this wasn't a distraction from that. Thanks! -shire